SOLR-15831: Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI #504
Conversation
thelabdude
changed the title
… possible to reduce OS specific scripting bin/solr
|
Boy I wish I had seen this PR a long time ago... A lot of good stuff in here... |
|
Hey @thelabdude I went through this PR, and I think at this point I've combed out all the good stuff in this PR already and have committed them in various PR's. Are you comfortable with me closing this PR to tidy up our list? (Also cause I keep re-reading it every few weeks thinking that I missed an inprogress PR!). |
|
Assigning to myself to do one more pass through for pulling "the good stuff out" and then will close it. |
|
Some of the ideas in this PR ended up in #2545 as well. I am going to look a bit more at how PackageTool does it's extended help information, and see if we can use that approach more in other tools, and reduce what's in |
|
I believe I've pulled all the good stuff into the new PR #2580 . @thelabdude would love any review ;-)! |
https://issues.apache.org/jira/browse/SOLR-15831
Start of some much needed clean-up of the bin/solr scripts! In this PR, I'm mainly removing usage information from the OS specific scripts (
bin/solrandbin\solr.cmd) and instead delegating the usage output to theSolrCLIJava code. There's no reason to maintain command usage info in 3 places!