-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 'latest' remain in URL instead of 9_0
#846
Make 'latest' remain in URL instead of 9_0
#846
Conversation
I can't really give a review on this PR as I don't know Antorra. If you want by comment: I don't think this will change Google's ranking, there are pros and cons:
So I am mixed feelings. As coming from "science" where persistent URLs for each verison are important, I tend to think that redirecting to "latest" is not best idea. From a business person opinion of course linking to latest is fine. If both works: No redirect and both pages are visible next to each other with separate URLs, I would be happy. But the page should have a "canonic url" meta header to inform Google about the duplicates and which version is the one to "bookmark" (the versioned one). |
Ideally I'd also want that both '9_0' and 'latest' will work, but I cannot see that as a choice at https://docs.antora.org/antora/latest/playbook/urls-latest-version-segment-strategy/#key? Antora supports canonical URL header: https://docs.antora.org/antora/latest/playbook/site-url/#canonical-url which is good news, so if we redirect to "latest", but canonical remains "9_0" then we could be good? |
Maybe do it the other way round: If the canonical URL is always "latest" (as described in the documentation), then Google would forget all old versions and only show links to latest. Thats actually a good thing and would solve our problems. We should maybe think of patching all old pages with a canonical link, too. Or much better instead of patching, we could add a HTTP "Link:" header (see Google Docs above) to the |
+1, we want I have tested this, and the current logic will set the canonical link to
We should certainly add this and it shouldn't be hard to do. I am often annoyed with the AWS docs, trying to link to the specific latest version.
We definitely need to do something about the Solr 6-8 releases. Generally only the pages that don't exist in Somewhat sane suggestion: We make a |
I have a list of pages that once existed but no longer does in 9.0: |
A robots.txt to hide the old releases looks like a good idea. We can just link all URL prefixes and we're done. Exlicitely allowing some older pages could also be done. Instead of an old-style robots.txt we may also use a |
Yes I was actually about to start implementing this. I think it's the way to go. |
Ok I have this: 78ecec9 It'll be an absolute pain to test, and I'm sure it doesn't work out-of-the box. But it's not required for the 9.0 release, so we can tinker with it. |
Ich think you should be able to do some tests with |
I was able to test docker run --rm --name httpd -p 8000:80 -v /Users/janhoy/git/solr-site/output:/usr/local/apache2/htdocs/ -v $(pwd)/my-httpd.conf:/usr/local/apache2/conf/httpd.conf httpd |
I realize this PR is merged (and thanks!), but I have a couple of questions that follow logically on the conversation here, so:
|
Spinoff from #77 - do not rewrite
latest
to9_0
, but opposite, so that people are encouraged to sharinglatest
links.Note that it will still be possible to share an explicit link to 9.0 version, that will be sure to route to the 9.0 guide. Just that the 'default' will be
latest
when working with the latest version.This may perhaps also help in boosting the PageRank of
latest
links in search engines?