SOLR-16230: JWT nested roles support #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java
Show resolved
Hide resolved
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java
Outdated
Show resolved
Hide resolved
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java
Outdated
Show resolved
Hide resolved
janhoy
reviewed
Sep 8, 2022
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java
Outdated
Show resolved
Hide resolved
janhoy
reviewed
Sep 8, 2022
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java
Outdated
Show resolved
Hide resolved
janhoy
reviewed
Sep 8, 2022
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java
Show resolved
Hide resolved
…TAuthPlugin.java Co-authored-by: Jan Høydahl <janhoy@users.noreply.github.com>
…TAuthPlugin.java Co-authored-by: Jan Høydahl <janhoy@users.noreply.github.com>
epugh
approved these changes
Sep 11, 2022
There was a problem hiding this comment.
This looks great. My one comment isn't really a request for change... I really like the addition to the Ref Guide, but I find that no matter what "words" we use, it's all very hard to understand how keycloak works! Someday, maybe some nice examples, versus trying to explain how it works?
janhoy
reviewed
Sep 11, 2022
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java
Outdated
Show resolved
Hide resolved
|
Thanks for looking at this |
janhoy
added a commit
that referenced
this pull request
Sep 14, 2022
Co-authored-by: Jan Høydahl <janhoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16230
Description
JWT-Auth: Support for Keycloak-Style nested roles
Solution
Introduce the support for
dot-notationinrolesClaimwhich assumes that the underlying element is a map with nested resolve capability.Tests
Please see the contained test
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.