[SPARK-51971] Improve DataFrame.collect to return the original values
#99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this PR, @viirya ? Now, |
viirya
reviewed
May 1, 2025
| case ArrowType.ArrowBinary: | ||
| values.append((array as! AsString).asString(i).utf8) | ||
| case .complexInfo(.strct): | ||
| values.append((array as! AsString).asString(i)) |
There was a problem hiding this comment.
We don't support nested types for now, right?
There was a problem hiding this comment.
Yes, all complex types are still under development.
viirya
approved these changes
May 1, 2025
|
Thank you, @viirya . Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to improve
DataFrame.collectto return the original values.Note that this PR provides simple value types first. More types like
Decimalwill be added later.Why are the changes needed?
The initial implementation has a limitation to return rows of
Stringvalues.Does this PR introduce any user-facing change?
No, because there is no released versions yet.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.