Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jenkins from pages #442

Conversation

bjornjorgensen
Copy link
Contributor

@bjornjorgensen bjornjorgensen commented Feb 25, 2023

bundle exec jekyll build --watch

Removed info about Jerkins from the developer-tools.md fil

  Regenerating: 1 file(s) changed at 2023-02-25 15:14:42
                developer-tools.md
                ...done in 2.778396909 seconds.

We don't use Jenkins anymore so we can remove this info.

@bjornjorgensen
Copy link
Contributor Author

hmm.. there is one more

"If you open a pull request containing binary incompatibilities anyway, Jenkins will remind you by failing the test build with the following message:

Test build #xx has finished for PR yy at commit ffffff.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes."

should I remove this one to?

@bjornjorgensen
Copy link
Contributor Author

And in https://spark.apache.org/release-process.html

"It is also good to set up Jenkins jobs for the release branch once it is cut to ensure tests are passing. These are jobs like https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test/job/spark-branch-2.3-test-maven-hadoop-2.7/ . Consult Josh Rosen and Shane Knapp for help with this. Also remember to add the newly-added jobs to the test dashboard at https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/ ."

"Also check that all build and test passes are green from the RISELab Jenkins: https://amplab.cs.berkeley.edu/jenkins/ particularly look for Spark Packaging, QA Compile, QA Test. Note that not all permutations are run on PR therefore it is important to check Jenkins runs."

@bjornjorgensen
Copy link
Contributor Author

and in https://spark.apache.org/contributing.html

"The Jenkins automatic pull request builder will test your changes
If it is your first contribution, Jenkins will wait for confirmation before building your code and post “Can one of the admins verify this patch?”
A committer can authorize testing with a comment like “ok to test”
A committer can automatically allow future pull requests from a contributor to be tested with a comment like “Jenkins, add to whitelist”
After about 2 hours, Jenkins will post the results of the test to the pull request, along with a link to the full results on Jenkins.
Watch for the results, and investigate and fix failures promptly
Fixes can simply be pushed to the same branch from which you opened your pull request
Jenkins will automatically re-test when new commits are pushed
If the tests failed for reasons unrelated to the change (e.g. Jenkins outage), then a committer can request a re-test with “Jenkins, retest this please”. Ask if you need a test restarted. If you were added by “Jenkins, add to whitelist” from a committer before, you can also request the re-test."

@bjornjorgensen bjornjorgensen marked this pull request as draft February 25, 2023 15:30
@bjornjorgensen
Copy link
Contributor Author

Now there are something about running jenkins test on github enterprise that are left I hope. https://spark.apache.org/docs/latest/building-spark.html#running-jenkins-tests-with-github-enterprise

Where should I remove this one then?

@bjornjorgensen bjornjorgensen changed the title Remove Jenkins from dev-tools page Remove Jenkins from pages Feb 25, 2023
@bjornjorgensen bjornjorgensen marked this pull request as ready for review February 25, 2023 18:43
@bjornjorgensen
Copy link
Contributor Author

@dongjoon-hyun FYI

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. @bjornjorgensen and @srowen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants