[SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTransformer user guide and example code #10006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, test this please. |
|
Test build #46770 has finished for PR 10006 at commit
|
|
Test build #46771 has finished for PR 10006 at commit
|
| @@ -35,4 +35,4 @@ Collate: | |||
| 'sparkR.R' | |||
| 'stats.R' | |||
| 'types.R' | |||
| 'utils.R' | |||
| 'utils.R' | |||
|
LGTM except one minor issue commented inline. |
|
Test build #46928 has finished for PR 10006 at commit
|
| Currently we only support SQL syntax like `"SELECT ... FROM __THIS__ ..."` | ||
| where `"__THIS__"` represents the underlying table of the input dataset. | ||
| The select clause specifies the fields, constants, and expressions to display in | ||
| the output, it can be any select clause that Spark SQL supported. Users can also |
There was a problem hiding this comment.
supports and not supported
|
There are a few typos which need to be corrected, but otherwise it looks good. |
|
Test build #47110 has finished for PR 10006 at commit
|
| @@ -1591,6 +1591,65 @@ transformer.transform(df).show() | |||
|
|
|||
| </div> | |||
|
|
|||
| ## SQLTransformer | |||
|
|
|||
| `SQLTransformer` implements the transforms which are defined by SQL statement. | |||
There was a problem hiding this comment.
Shouldn't this be "the transformation which are defined by a SQL statement"?
|
Test build #47181 has finished for PR 10006 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Dec 8, 2015
…mple code Add ```SQLTransformer``` user guide, example code and make Scala API doc more clear. Author: Yanbo Liang <ybliang8@gmail.com> Closes #10006 from yanboliang/spark-11958. (cherry picked from commit 4a39b5a) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
Merged into master and branch-1.6. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SQLTransformeruser guide, example code and make Scala API doc more clear.