[SPARK-15075] [SQL] Cleanup dependencies between SQLContext and SparkSession #13102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilipbiswal
changed the title
|
Test build #58589 has finished for PR 13102 at commit
|
|
cc @rxin |
|
Sorry this is not what I meant in the JIRA ticket. What I meant was that we should just save SparkSessions, and then SQLContext calls into that. I didn't mean to literally move the code from SQLContext into SparkSession. |
|
@rxin Thank you reynold for handling this. It was taking me a lot of time to understand the dependencies. Thanks again .. I will close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We currently in SparkSession.Builder use SQLContext.getOrCreate. It should probably the the other way around, i.e. all the core logic goes in SparkSession, and SQLContext just calls that.
How was this patch tested?
Made sure existing tests pass.