Skip to content

Conversation

jiayue-zhang
Copy link
Contributor

What changes were proposed in this pull request?

Add Scala/Java/Python examples for MinHash and RandomProjection

How was this patch tested?

./bin/run-example ml.MinHashExample
./bin/run-example ml.JavaMinHashExample
./bin/run-example ml.RandomProjectionExample
./bin/run-example ml.JavaRandomProjectionExample

@yanboliang
Copy link
Contributor

@jkbradley @MLnick @srowen Could you help to add @bravo-zhang to whitelist? Thanks.

@srowen
Copy link
Member

srowen commented Nov 7, 2016

Jenkins add to whitelist

@srowen
Copy link
Member

srowen commented Nov 7, 2016

Looking good, excepting that there are no python examples?

@yanboliang
Copy link
Contributor

yanboliang commented Nov 7, 2016

@srowen The Python API is still waiting for review at #15768. Would you mind to take a look? Thanks.

@SparkQA
Copy link

SparkQA commented Nov 7, 2016

Test build #68271 has finished for PR 15787 at commit 8a086a0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class JavaMinHashExample
    • public class JavaRandomProjectionExample

@srowen
Copy link
Member

srowen commented Nov 7, 2016

OK, to keep this straight: let's remove "Python" from this JIRA and PR and get it in. The Python API JIRA, SPARK-18010, should also add examples if possible.

However this seems to overlap with SPARK-18081. I think this needs to coordinate what examples are being added.

@jiayue-zhang jiayue-zhang changed the title [SPARK-18286][ML][WIP] Add Scala/Java/Python examples for MinHash and RandomProjection [SPARK-18286][ML] Add Scala/Java examples for MinHash and RandomProjection Nov 7, 2016
@SparkQA
Copy link

SparkQA commented Nov 7, 2016

Test build #68282 has finished for PR 15787 at commit 78593e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK to me, though given how much is being discussed in SPARK-18081 it might even be better to make sure this is consistent with its outcome, which also includes examples.

@jkbradley
Copy link
Member

Linking [https://issues.apache.org/jira/browse/SPARK-18392] since it will alter the public API for LSH

@jiayue-zhang
Copy link
Contributor Author

This PR can be closed since #15795 has merged

@jkbradley
Copy link
Member

Ah, thank you @bravo-zhang !

@jiayue-zhang jiayue-zhang deleted the spark-18286 branch August 2, 2017 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants