-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-18286][ML] Add Scala/Java examples for MinHash and RandomProjection #15787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… RandomProjection
@jkbradley @MLnick @srowen Could you help to add @bravo-zhang to whitelist? Thanks. |
Jenkins add to whitelist |
Looking good, excepting that there are no python examples? |
Test build #68271 has finished for PR 15787 at commit
|
OK, to keep this straight: let's remove "Python" from this JIRA and PR and get it in. The Python API JIRA, SPARK-18010, should also add examples if possible. However this seems to overlap with SPARK-18081. I think this needs to coordinate what examples are being added. |
Test build #68282 has finished for PR 15787 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks OK to me, though given how much is being discussed in SPARK-18081 it might even be better to make sure this is consistent with its outcome, which also includes examples.
Linking [https://issues.apache.org/jira/browse/SPARK-18392] since it will alter the public API for LSH |
This PR can be closed since #15795 has merged |
Ah, thank you @bravo-zhang ! |
What changes were proposed in this pull request?
Add Scala/Java/Python examples for MinHash and RandomProjection
How was this patch tested?
./bin/run-example ml.MinHashExample
./bin/run-example ml.JavaMinHashExample
./bin/run-example ml.RandomProjectionExample
./bin/run-example ml.JavaRandomProjectionExample