Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Close stale PRs #16937

Closed
wants to merge 1 commit into from
Closed

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Feb 15, 2017

What changes were proposed in this pull request?

This PR proposes to close stale PRs.

What I mean by "stale" here includes that there are some review comments by reviewers but the author looks inactive without any answer to them more than a month.

I left some comments roughly a week ago to ping and the author looks still inactive in these PR below

These below includes some PR suggested to be closed and a PR against another branch which seems obviously inappropriate.

Given the comments in the last three PRs below, they are probably worth being taken over by anyone who is interested in it.

Closes #7963
Closes #8374
Closes #11192
Closes #11374
Closes #11692
Closes #12243
Closes #12583
Closes #12620
Closes #12675
Closes #12697
Closes #12800
Closes #13715
Closes #14266
Closes #15053
Closes #15159
Closes #15209
Closes #15264
Closes #15267
Closes #15871
Closes #15861
Closes #16319
Closes #16324
Closes #16890

Closes #12398
Closes #12933
Closes #14517

How was this patch tested?

N/A

@HyukjinKwon
Copy link
Member Author

cc @srowen.

@HyukjinKwon
Copy link
Member Author

Please yell at me if any author of the PRs is active. I will definitely take it out.

@SparkQA
Copy link

SparkQA commented Feb 15, 2017

Test build #72931 has finished for PR 16937 at commit 464522a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Feb 15, 2017

I am OK with closing these purely because they're inactive, and, it's trivial to reopen one if desired. PRs ought to reach a resolution rapidly.

Ideally, if the resolution seems to be that the issue isn't an issue, or that the change shouldn't be made, also close the JIRA. If it's a plausible change and the PR just got orphaned, and the JIRA looks possibly relevant still at all, it can be left.

@asfgit asfgit closed this in ed338f7 Feb 17, 2017
@HyukjinKwon HyukjinKwon deleted the stale-prs-close branch January 2, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants