[SPARK-22178] [SQL] Refresh Persistent Views by REFRESH TABLE Command #19405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #82365 has finished for PR 19405 at commit
|
|
cc @cloud-fan |
viirya
reviewed
Oct 2, 2017
| // Non-temp tables: refresh the metadata cache. | ||
| sessionCatalog.refreshTable(tableIdent) | ||
|
|
||
| val tableMetadata = sessionCatalog.getTempViewOrPermanentTableMetadata(tableIdent) | ||
| // If this table is cached as an InMemoryRelation, drop the original |
There was a problem hiding this comment.
This comment should be moved to line 491.
jiangxb1987
approved these changes
Oct 3, 2017
| checkRefreshView(isTemp = true) | ||
| } | ||
|
|
||
| test("view refresh") { |
There was a problem hiding this comment.
We didn't cover the persistent view case for refresh, that's why the bug happens...
There was a problem hiding this comment.
Yes. We need to ask contributors for adding more test cases when reviewing the PR.
|
LGTM except for one minor comment. |
|
Test build #82425 has finished for PR 19405 at commit
|
|
Thanks! Merged to master/2.2 |
asfgit
pushed a commit
that referenced
this pull request
Oct 3, 2017
## What changes were proposed in this pull request? The underlying tables of persistent views are not refreshed when users issue the REFRESH TABLE command against the persistent views. ## How was this patch tested? Added a test case Author: gatorsmile <gatorsmile@gmail.com> Closes #19405 from gatorsmile/refreshView. (cherry picked from commit e65b6b7) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
## What changes were proposed in this pull request? The underlying tables of persistent views are not refreshed when users issue the REFRESH TABLE command against the persistent views. ## How was this patch tested? Added a test case Author: gatorsmile <gatorsmile@gmail.com> Closes apache#19405 from gatorsmile/refreshView. (cherry picked from commit e65b6b7) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The underlying tables of persistent views are not refreshed when users issue the REFRESH TABLE command against the persistent views.
How was this patch tested?
Added a test case