-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-22324][SQL][PYTHON] Upgrade Arrow to 0.8.0 #19884
Closed
BryanCutler
wants to merge
17
commits into
apache:master
from
BryanCutler:arrow-upgrade-080-SPARK-22324
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2311fa2
Upgrade Netty to 4.1.17
zsxwing 9d78299
Fix ProtocolSuite
zsxwing de67ce2
Add AbstractFileRegion
zsxwing 1779dc3
initial code update for Arrow 0.8 after java refactor, most tests pas…
BryanCutler cbf6b97
updated JSON NaN to work with newer Jackson parser
BryanCutler feba0d0
fixed for latest Arrow master, removed Nullable prefix, removed vecto…
BryanCutler 12812d8
fixed problems with type checking
BryanCutler 0590f8a
removed casting workarounds in serializers, pyspark tests pass
BryanCutler d52b2af
no longer need to keep closed flag in toPayloadIterator
BryanCutler 22c6b92
added requirement for minimum pyarrow version
BryanCutler 2149f72
moved pyarrow version check to sql.utils
BryanCutler 0047f7a
change ArrowPythonRunner EOS to close the reader while keeping input …
BryanCutler d92ae90
reworked udf pyarrow check
BryanCutler faa9f09
make PandasUDFTests conditional on Pandas installed
BryanCutler 423b68c
need to skip doctest lines with pandas_udf
BryanCutler ae84c84
workaround for timestamp casting
BryanCutler b0200ef
revert doctest result
BryanCutler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
common/network-common/src/main/java/org/apache/spark/network/util/AbstractFileRegion.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.network.util; | ||
|
||
import io.netty.channel.FileRegion; | ||
import io.netty.util.AbstractReferenceCounted; | ||
|
||
public abstract class AbstractFileRegion extends AbstractReferenceCounted implements FileRegion { | ||
|
||
@Override | ||
@SuppressWarnings("deprecation") | ||
public final long transfered() { | ||
return transferred(); | ||
} | ||
|
||
@Override | ||
public AbstractFileRegion retain() { | ||
super.retain(); | ||
return this; | ||
} | ||
|
||
@Override | ||
public AbstractFileRegion retain(int increment) { | ||
super.retain(increment); | ||
return this; | ||
} | ||
|
||
@Override | ||
public AbstractFileRegion touch() { | ||
super.touch(); | ||
return this; | ||
} | ||
|
||
@Override | ||
public AbstractFileRegion touch(Object o) { | ||
return this; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks binary compatibility. Is it intentional? @zsxwing @cloud-fan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't. The old method is implemented in
AbstractFileRegion.transfered
. In addition, the whole network module is private, we don't need to maintain compatibility.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see.
AbstractFileRegion.transfered
isfinal
so it may break binary compatibility. However, this is fine since it's a private module.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks!