[SPARK-22832][ML] BisectingKMeans unpersist unused datasets #20017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85104 has finished for PR 20017 at commit
|
|
ping @srowen |
srowen
requested changes
Dec 19, 2017
| @@ -212,7 +212,9 @@ class BisectingKMeans private ( | |||
| } | |||
| level += 1 | |||
| } | |||
| if(indices != null) indices.unpersist() | |||
| if (preIndices != null) preIndices.unpersist(blocking = false) | |||
There was a problem hiding this comment.
Do we usually write "blocking ="? there's only one argument.
I'd use braces and put the body on the next line too.
|
Test build #85144 has finished for PR 20017 at commit
|
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
unpersist unused datasets
How was this patch tested?
existing tests and local check in Spark-Shell