Skip to content

Conversation

rekhajoshm
Copy link
Contributor

What changes were proposed in this pull request?

Removed @export tag to get rid of unknown tag warnings

How was this patch tested?

Existing tests

rekhajoshm added 11 commits May 5, 2015 16:10
Pulling functionality from apache spark
pull latest from apache spark
Pulling functionality from apache spark
Pulling functionality from apache spark
pull request from apache/master
pull latest from apache spark
pull latest from apache spark
pull latest apache spark
Apache spark pull latest
@SparkQA
Copy link

SparkQA commented Feb 4, 2018

Test build #87040 has finished for PR 20501 at commit 7db58db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

I'm/We're aware of this and to keep diff small and manageable for backporting fixes, it is preferable to avoid broad changes like this.

We can revisit when new releases are stable down, perhaps.

@srowen
Copy link
Member

srowen commented Feb 4, 2018

I see this too and Roxygen 6.0.1 seems common now. Is there any value to the tags? I don't think these removals can cause much merge conflict. It can go in master right?

@felixcheung
Copy link
Member

It was not used in the current way we have the export and a change in 6.x started warning about this.

Jenkins is not running Roxygen 6 though. There are pending tasks to upgrade. IMO it's better to update our toolset and validate the doc output is correct officially and then remove these tags for the warnings. The warnings are harmless.

Historically a lot of changes get backported around a new releases (or RCs of releases) and it was a pain to hand merge every single commit.

@rekhajoshm
Copy link
Contributor Author

Ack. thanks for the update @felixcheung @srowen Closing this.

@rekhajoshm rekhajoshm closed this Feb 9, 2018
@felixcheung
Copy link
Member

@rekhajoshm feel free to follow up after we are through with 2.3.0, thanks!

@srowen
Copy link
Member

srowen commented Feb 28, 2018

@rekhajoshm @felixcheung since 2.3.0 was just finished, OK to merge?

@felixcheung
Copy link
Member

can you reopen this PR and add [R] in the title?

@felixcheung
Copy link
Member

ping @rekhajoshm ?

@rekhajoshm rekhajoshm reopened this Mar 5, 2018
@rekhajoshm rekhajoshm changed the title [SPARK-22430][Docs] Unknown tag warnings when building R docs with Roxygen 6.0.1 [SPARK-22430][R][Docs] Unknown tag warnings when building R docs with Roxygen 6.0.1 Mar 5, 2018
@rekhajoshm
Copy link
Contributor Author

done @felixcheung thanks

@SparkQA
Copy link

SparkQA commented Mar 5, 2018

Test build #87949 has finished for PR 20501 at commit 7db58db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

merged to master

@asfgit asfgit closed this in 4586ead Mar 5, 2018
mgaido91 pushed a commit to mgaido91/spark that referenced this pull request Mar 5, 2018
… Roxygen 6.0.1

## What changes were proposed in this pull request?
Removed export tag to get rid of unknown tag warnings

## How was this patch tested?
Existing tests

Author: Rekha Joshi <rekhajoshm@gmail.com>
Author: rjoshi2 <rekhajoshm@gmail.com>

Closes apache#20501 from rekhajoshm/SPARK-22430.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants