-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-22430][R][Docs] Unknown tag warnings when building R docs with Roxygen 6.0.1 #20501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pulling functionality from apache spark
pull latest from apache spark
Pulling functionality from apache spark
Pulling functionality from apache spark
pull request from apache/master
pull latest from apache spark
pull latest from apache spark
Pull apache spark
pull latest apache spark
Apache spark pull latest
Test build #87040 has finished for PR 20501 at commit
|
I'm/We're aware of this and to keep diff small and manageable for backporting fixes, it is preferable to avoid broad changes like this. We can revisit when new releases are stable down, perhaps. |
I see this too and Roxygen 6.0.1 seems common now. Is there any value to the tags? I don't think these removals can cause much merge conflict. It can go in master right? |
It was not used in the current way we have the export and a change in 6.x started warning about this. Jenkins is not running Roxygen 6 though. There are pending tasks to upgrade. IMO it's better to update our toolset and validate the doc output is correct officially and then remove these tags for the warnings. The warnings are harmless. Historically a lot of changes get backported around a new releases (or RCs of releases) and it was a pain to hand merge every single commit. |
Ack. thanks for the update @felixcheung @srowen Closing this. |
@rekhajoshm feel free to follow up after we are through with 2.3.0, thanks! |
@rekhajoshm @felixcheung since 2.3.0 was just finished, OK to merge? |
can you reopen this PR and add [R] in the title? |
ping @rekhajoshm ? |
done @felixcheung thanks |
Test build #87949 has finished for PR 20501 at commit
|
merged to master |
… Roxygen 6.0.1 ## What changes were proposed in this pull request? Removed export tag to get rid of unknown tag warnings ## How was this patch tested? Existing tests Author: Rekha Joshi <rekhajoshm@gmail.com> Author: rjoshi2 <rekhajoshm@gmail.com> Closes apache#20501 from rekhajoshm/SPARK-22430.
What changes were proposed in this pull request?
Removed @export tag to get rid of unknown tag warnings
How was this patch tested?
Existing tests