[SPARK-24056] [SS] Make consumer creation lazy in Kafka source for Structured streaming #21134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdas
changed the title
tdas
changed the title
|
Test build #89744 has finished for PR 21134 at commit
|
|
Test build #89750 has finished for PR 21134 at commit
|
|
Test build #89771 has finished for PR 21134 at commit
|
brkyvz
approved these changes
Apr 24, 2018
| val kafkaReaderThread = Executors.newSingleThreadExecutor(new ThreadFactory { | ||
| override def newThread(r: Runnable): Thread = { | ||
| val t = new UninterruptibleThread("Kafka Offset Reader") { | ||
| val t = new UninterruptibleThread(s"Kafka Offset Reader") { |
|
Test build #89801 has finished for PR 21134 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the driver side of the Kafka source (i.e. KafkaMicroBatchReader) eagerly creates a consumer as soon as the Kafk aMicroBatchReader is created. However, we create dummy KafkaMicroBatchReader to get the schema and immediately stop it. Its better to make the consumer creation lazy, it will be created on the first attempt to fetch offsets using the KafkaOffsetReader.
How was this patch tested?
Existing unit tests