[SPARK-24883][SQL]Avro: remove implicit class AvroDataFrameWriter/AvroDataFrameReader #21841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #93417 has finished for PR 21841 at commit
|
|
@gengliangwang Could you address the conflicts? |
|
@gengliangwang, looks JIRA link is wrong. you mean SPARK-24883? |
gengliangwang
force-pushed
the
removeImplicit
branch
from
30e09f8 to
06a80bb
Compare
gengliangwang
changed the title
|
@HyukjinKwon Thanks for reminding! I have corrected it. |
|
Test build #93433 has finished for PR 21841 at commit
|
|
Merged to master. |
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…roDataFrameReader As per Reynold's comment: apache#21742 (comment) It makes sense to remove the implicit class AvroDataFrameWriter/AvroDataFrameReader, since the Avro package is external module. Unit test Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21841 from gengliangwang/removeImplicit. (cherry picked from commit f59de52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As per Reynold's comment: #21742 (comment)
It makes sense to remove the implicit class AvroDataFrameWriter/AvroDataFrameReader, since the Avro package is external module.
How was this patch tested?
Unit test