Skip to content

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Mar 25, 2019

What changes were proposed in this pull request?

Followup to PR #17085
This PR adds the weight column to the pyspark side, which was already added to the scala API.
The PR also undoes a name change in the scala side corresponding to a change in another similar PR as noted here:
#17084 (comment)

How was this patch tested?

This patch adds python tests for the changes to the pyspark API.

Please review http://spark.apache.org/contributing.html before opening a pull request.

@SparkQA
Copy link

SparkQA commented Mar 25, 2019

Test build #103885 has finished for PR 24197 at commit b26b0f5.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@imatiach-msft imatiach-msft force-pushed the ilmat/regressor-eval-python branch from b26b0f5 to 494e8aa Compare March 25, 2019 03:05
@SparkQA
Copy link

SparkQA commented Mar 25, 2019

Test build #103886 has finished for PR 24197 at commit 494e8aa.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, yeah seems consistent given the other PRs

@imatiach-msft imatiach-msft force-pushed the ilmat/regressor-eval-python branch 2 times, most recently from d050f32 to f659fb2 Compare March 25, 2019 04:47
@SparkQA
Copy link

SparkQA commented Mar 25, 2019

Test build #103891 has finished for PR 24197 at commit d050f32.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@SparkQA
Copy link

SparkQA commented Mar 25, 2019

Test build #103893 has finished for PR 24197 at commit f659fb2.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Mar 25, 2019

Test build #103898 has finished for PR 24197 at commit f659fb2.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

…spark API for regression evaluator and metrics
@imatiach-msft imatiach-msft force-pushed the ilmat/regressor-eval-python branch from f659fb2 to 4cb2137 Compare March 26, 2019 02:35
@SparkQA
Copy link

SparkQA commented Mar 26, 2019

Test build #103939 has finished for PR 24197 at commit 4cb2137.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@imatiach-msft
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Mar 26, 2019

Test build #103945 has finished for PR 24197 at commit 4cb2137.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, HasWeightCol,

@srowen
Copy link
Member

srowen commented Mar 26, 2019

Merged to master

@srowen srowen closed this in 887279c Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants