[SPARK-43936][SQL] Fix bug for toSQLId #41430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hisoka-X
approved these changes
Jun 2, 2023
panbingkun
changed the title
|
Manually test as follow: |
panbingkun
changed the title
|
local check |
Let me fix the above issue in another separate PR, as the issues mentioned in the PR currently hinder the GA process. |
|
@panbingkun can you just fix it here togheter? |
|
Okay, the tests are almost done. Let's get this merged first. |
|
@panbingkun Thank you for the fix. I'm waiting this one merged. |
LuciferYang
approved these changes
Jun 2, 2023
|
All passed, let me merge this one |
|
Merged to master. Thanks @panbingkun @HyukjinKwon @beliefer @yikf @Hisoka-X |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? The pr aims to fix issue for QueryErrorBase.toSQLId. eg: 1.https://github.com/beliefer/spark/actions/runs/5144414857/jobs/9261862936 2.https://github.com/panbingkun/spark/actions/runs/5145364900/jobs/9262927798 3.https://github.com/panbingkun/spark/actions/runs/5143676069/jobs/9259636037 ### Why are the changes needed? After SPARK-43910, `__auto_generated_subquery_name` from ids in errors should remove, but when the type of `parts` is ArrayBuffer, match will fail. causing unexpected behavior. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manually test. - Pass GA. Closes apache#41430 from panbingkun/fix_bug_natural_join. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to fix issue for QueryErrorBase.toSQLId.
eg:
1.https://github.com/beliefer/spark/actions/runs/5144414857/jobs/9261862936
2.https://github.com/panbingkun/spark/actions/runs/5145364900/jobs/9262927798
3.https://github.com/panbingkun/spark/actions/runs/5143676069/jobs/9259636037
Why are the changes needed?
After SPARK-43910,
__auto_generated_subquery_namefrom ids in errors should remove, but when the type ofpartsis ArrayBuffer, match will fail. causing unexpected behavior.Does this PR introduce any user-facing change?
No.
How was this patch tested?