-
Notifications
You must be signed in to change notification settings - Fork 28.8k
[SPARK-47453][SQL][DOCKER][BUILD][TESTS] Upgrade MySQL docker image version to 8.3.0 #45581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (Pending CIs), @yaooqinn .
Merged to master for Apache Spark 4.0.0. |
Thank you @dongjoon-hyun |
Hi, @yaooqinn and @dongjoon-hyun, MySQL 8.3 is not an LTS version while 8.0 is, as an RDBMS, a non-LTS version is not likely adopted widely than LTS. https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/ Also, Spark officially only supports LTS Java versions, like JDK 17 and 21, but not 22. I would recommend using MySQL 8.0 until the next LTS version is available. |
It's an interesting suggestion. However, I don't think Apache Spark has such a community policy for MySQL LTS support so far, @pan3793 . Do you have a concern that MySQL community doesn't follow |
According to your request, why don't you send an email to initiate the discussion, @pan3793 ? We can make it as a new community policy (JDBC LTS?) if needed. |
Is it necessary for a test/dev dependency to be a strict LTS? Is it even comparable with policies of adopting JDKs?
According to suggestions by MySQL official https://dev.mysql.com/doc/refman/8.3/en/upgrade-paths.html
|
+1 for @yaooqinn ’s comment. |
@dongjoon-hyun thanks for your suggestion, I sent an email to the https://lists.apache.org/thread/rqso3mf3ll1p2sfw02wzcxbjo2xno6go @yaooqinn I would say, yes, MySQL(including the similar product provided by Cloud vendors, i.e. Amazon RDS for MySQL) is one of the most important infrastructures today.
|
Thank you. I replied. |
…ersion to 8.3.0 ### What changes were proposed in this pull request? Upgrade MySQL docker image version to 8.3.0 ### Why are the changes needed? test dependencies upgrading ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? passed locally with: `./build/sbt -Pdocker-integration-tests "docker-integration-tests/testOnly *MySQLIntegrationSuite"` ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45581 from yaooqinn/SPARK-47453. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
Upgrade MySQL docker image version to 8.3.0
Why are the changes needed?
test dependencies upgrading
Does this PR introduce any user-facing change?
no
How was this patch tested?
passed locally with:
./build/sbt -Pdocker-integration-tests "docker-integration-tests/testOnly *MySQLIntegrationSuite"
Was this patch authored or co-authored using generative AI tooling?
no