Skip to content

Conversation

yaooqinn
Copy link
Member

What changes were proposed in this pull request?

Upgrade MySQL docker image version to 8.3.0

Why are the changes needed?

test dependencies upgrading

Does this PR introduce any user-facing change?

no

How was this patch tested?

passed locally with:
./build/sbt -Pdocker-integration-tests "docker-integration-tests/testOnly *MySQLIntegrationSuite"

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Mar 19, 2024
@yaooqinn yaooqinn requested a review from dongjoon-hyun March 19, 2024 03:28
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs), @yaooqinn .

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 4.0.0.

@yaooqinn
Copy link
Member Author

Thank you @dongjoon-hyun

@yaooqinn yaooqinn deleted the SPARK-47453 branch March 19, 2024 08:00
@pan3793
Copy link
Member

pan3793 commented Mar 25, 2024

Hi, @yaooqinn and @dongjoon-hyun, MySQL 8.3 is not an LTS version while 8.0 is, as an RDBMS, a non-LTS version is not likely adopted widely than LTS.

https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/

Also, Spark officially only supports LTS Java versions, like JDK 17 and 21, but not 22. I would recommend using MySQL 8.0 until the next LTS version is available.

@dongjoon-hyun
Copy link
Member

It's an interesting suggestion. However, I don't think Apache Spark has such a community policy for MySQL LTS support so far, @pan3793 .

Do you have a concern that MySQL community doesn't follow Semantic Versioning and will break something between 8.0 and 8.3?

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Mar 25, 2024

According to your request, why don't you send an email to initiate the discussion, @pan3793 ? We can make it as a new community policy (JDBC LTS?) if needed.

@yaooqinn
Copy link
Member Author

Is it necessary for a test/dev dependency to be a strict LTS? Is it even comparable with policies of adopting JDKs?

  • The connector/j version was bumped up before this server-side change.
  • It's nice to pre-check if any behavior changes when upgrading to the latest. So far so good.

According to suggestions by MySQL official https://dev.mysql.com/doc/refman/8.3/en/upgrade-paths.html

It is necessary to upgrade to the latest innovation releases (for example, from MySQL 8.2 to 8.3) regularly to keep up with the latest bug fixes and security patches.

@dongjoon-hyun
Copy link
Member

+1 for @yaooqinn ’s comment.

@pan3793
Copy link
Member

pan3793 commented Mar 25, 2024

@dongjoon-hyun thanks for your suggestion, I sent an email to the user/dev mailing list, but limited the scope to MySQL version policy since I have less knowledge of other RDBMS.

https://lists.apache.org/thread/rqso3mf3ll1p2sfw02wzcxbjo2xno6go

@yaooqinn I would say, yes, MySQL(including the similar product provided by Cloud vendors, i.e. Amazon RDS for MySQL) is one of the most important infrastructures today.

Is it even comparable with policies of adopting JDKs?

@dongjoon-hyun
Copy link
Member

sweisdb pushed a commit to sweisdb/spark that referenced this pull request Apr 1, 2024
…ersion to 8.3.0

### What changes were proposed in this pull request?

Upgrade MySQL docker image version to 8.3.0

### Why are the changes needed?

test dependencies upgrading

### Does this PR introduce _any_ user-facing change?

no
### How was this patch tested?

passed locally with:
`./build/sbt -Pdocker-integration-tests  "docker-integration-tests/testOnly *MySQLIntegrationSuite"`
### Was this patch authored or co-authored using generative AI tooling?

no

Closes apache#45581 from yaooqinn/SPARK-47453.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants