[SPARK-48054][PYTHON][CONNECT][INFRA] Backward compatibility test for Spark Connect #46298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nija-at
reviewed
Apr 30, 2024
|
A basic question about the "backward compatibility" policy: does it mean that the user can
|
|
For now, I am testing old client -> newer server case only. |
|
@pan3793 - user must use a lower (or same) version client to connect to a server ONLY. |
nija-at
reviewed
Apr 30, 2024
make sense, would be great to clarify that on the docs :) |
HyukjinKwon
force-pushed
the
SPARK-48054
branch
2 times, most recently
from
b9498ff
to
ac4d2d1
Compare
HyukjinKwon
force-pushed
the
SPARK-48054
branch
from
ac4d2d1
to
b00b659
Compare
|
For notes to my self: Tests being skipped for now |
HyukjinKwon
force-pushed
the
SPARK-48054
branch
5 times, most recently
from
2036352
to
1ee91df
Compare
|
Doctest: |
HyukjinKwon
force-pushed
the
SPARK-48054
branch
6 times, most recently
from
aa0bd35
to
e8c0bba
Compare
HyukjinKwon
force-pushed
the
SPARK-48054
branch
3 times, most recently
from
b6ce491
to
31ec47e
Compare
HyukjinKwon
force-pushed
the
SPARK-48054
branch
6 times, most recently
from
881bd0a
to
15ef1d3
Compare
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 21 * * *' |
There was a problem hiding this comment.
Thank you. Ya, +1 for adding this and this looks not a heavy.
After adding this, please monitor once if it works expected in the total budget.
There was a problem hiding this comment.
Thanks for the pointer!
|
Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
May 3, 2024
…5 client <> 4.0 server ### What changes were proposed in this pull request? This PR proposes to skip the tests that fail with 3.5 client and 4.0 server in Spark Connect (by adding `SPARK_SKIP_CONNECT_COMPAT_TESTS`). This is a base work for #46298. This partially backports #45870 This PR also adds `SPARK_CONNECT_TESTING_REMOTE` environment variable so developers can run PySpark unittests against a Spark Connect server. ### Why are the changes needed? In order to set up the CI that tests 3.5 client and 4.0 server in Spark Connect. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Tested it in my fork, see #46298 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46334 from HyukjinKwon/SPARK-48088. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
May 6, 2024
…to SPARK_SKIP_CONNECT_COMPAT_TESTS ### What changes were proposed in this pull request? This PR is a followup of #46298 that properly uses the environment variable SPARK_SKIP_CONNECT_COMPAT_TESTS added at #46334 ### Why are the changes needed? To recover the compatibility test (https://github.com/apache/spark/actions/runs/8961109352/job/24608366499). ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46394 from HyukjinKwon/SPARK-48054-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
… Spark Connect ### What changes were proposed in this pull request? This PR is a tentative try to run Spark 3.5 tests with Python Client 3.5 against Spark Connect server 4.0. ### Why are the changes needed? In order to make sure the compatibility between 3.5 and 4.0. ### Does this PR introduce _any_ user-facing change? No, testing-only. ### How was this patch tested? Within my own fork. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46298 from HyukjinKwon/SPARK-48054. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…to SPARK_SKIP_CONNECT_COMPAT_TESTS ### What changes were proposed in this pull request? This PR is a followup of apache#46298 that properly uses the environment variable SPARK_SKIP_CONNECT_COMPAT_TESTS added at apache#46334 ### Why are the changes needed? To recover the compatibility test (https://github.com/apache/spark/actions/runs/8961109352/job/24608366499). ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46394 from HyukjinKwon/SPARK-48054-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a tentative try to run Spark 3.5 tests with Python Client 3.5 against Spark Connect server 4.0.
Why are the changes needed?
In order to make sure the compatibility between 3.5 and 4.0.
Does this PR introduce any user-facing change?
No, testing-only.
How was this patch tested?
Within my own fork.
Was this patch authored or co-authored using generative AI tooling?
No.