[SPARK-48088][PYTHON][CONNECT][TESTS][3.5] Skip tests that fail in 3.5 client <> 4.0 server #46334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
SQL
ML
STRUCTURED STREAMING
CORE
PYTHON
PANDAS API ON SPARK
CONNECT
labels
HyukjinKwon
commented
May 2, 2024
| import unittest | ||
| from pyspark.sql import SparkSession | ||
| from pyspark.ml.tests.connect.test_legacy_mode_tuning import CrossValidatorTestsMixin | ||
|
|
||
|
|
||
| @unittest.skipIf("SPARK_SKIP_CONNECT_COMPAT_TESTS" in os.environ, "Requires JVM access") |
There was a problem hiding this comment.
I am going to forward port a bit of changes into master to reduce the diff later.
HyukjinKwon
force-pushed
the
SPARK-48088
branch
5 times, most recently
from
c695fd4
to
c8d13e8
Compare
There was a problem hiding this comment.
Oh, I thought Spark Connect is supposed to handle this, @HyukjinKwon .
Do you know what breaks the compatibility?
|
cc @grundprinzip , too |
dongjoon-hyun
approved these changes
May 2, 2024
|
I am triaging the breaking changes in the umbrella JIRA at https://issues.apache.org/jira/browse/SPARK-48082. They are mostly because of new features so it seems not so bad. |
dongjoon-hyun
approved these changes
May 3, 2024
dongjoon-hyun
approved these changes
May 3, 2024
|
Merged to branch-3.5. I will perpare separate forward port PR |
HyukjinKwon
added a commit
that referenced
this pull request
May 3, 2024
…5 client <> 4.0 server ### What changes were proposed in this pull request? This PR proposes to skip the tests that fail with 3.5 client and 4.0 server in Spark Connect (by adding `SPARK_SKIP_CONNECT_COMPAT_TESTS`). This is a base work for #46298. This partially backports #45870 This PR also adds `SPARK_CONNECT_TESTING_REMOTE` environment variable so developers can run PySpark unittests against a Spark Connect server. ### Why are the changes needed? In order to set up the CI that tests 3.5 client and 4.0 server in Spark Connect. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Tested it in my fork, see #46298 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46334 from HyukjinKwon/SPARK-48088. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 3, 2024
…test 4.0 <> above ### What changes were proposed in this pull request? This PR forward ports #46334 to reduce conflicts. ### Why are the changes needed? To reduce the conflict against branch-3.5, and prepare 4.0 <> above test. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? CI in this PR should verify them. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46358 from HyukjinKwon/SPARK-48088-40. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
HyukjinKwon
added a commit
that referenced
this pull request
May 6, 2024
…to SPARK_SKIP_CONNECT_COMPAT_TESTS ### What changes were proposed in this pull request? This PR is a followup of #46298 that properly uses the environment variable SPARK_SKIP_CONNECT_COMPAT_TESTS added at #46334 ### Why are the changes needed? To recover the compatibility test (https://github.com/apache/spark/actions/runs/8961109352/job/24608366499). ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46394 from HyukjinKwon/SPARK-48054-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 7, 2024
…hat that requires JVM access ### What changes were proposed in this pull request? This PR is a followup of #46334 that missed one more test case. ### Why are the changes needed? See #46334 ### Does this PR introduce _any_ user-facing change? See #46334 ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46411 from HyukjinKwon/SPARK-48088-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…test 4.0 <> above ### What changes were proposed in this pull request? This PR forward ports apache#46334 to reduce conflicts. ### Why are the changes needed? To reduce the conflict against branch-3.5, and prepare 4.0 <> above test. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? CI in this PR should verify them. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46358 from HyukjinKwon/SPARK-48088-40. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…to SPARK_SKIP_CONNECT_COMPAT_TESTS ### What changes were proposed in this pull request? This PR is a followup of apache#46298 that properly uses the environment variable SPARK_SKIP_CONNECT_COMPAT_TESTS added at apache#46334 ### Why are the changes needed? To recover the compatibility test (https://github.com/apache/spark/actions/runs/8961109352/job/24608366499). ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46394 from HyukjinKwon/SPARK-48054-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to skip the tests that fail with 3.5 client and 4.0 server in Spark Connect (by adding
SPARK_SKIP_CONNECT_COMPAT_TESTS). This is a base work for #46298. This partially backports #45870This PR also adds
SPARK_CONNECT_TESTING_REMOTEenvironment variable so developers can run PySpark unittests against a Spark Connect server.Why are the changes needed?
In order to set up the CI that tests 3.5 client and 4.0 server in Spark Connect.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Tested it in my fork, see #46298
Was this patch authored or co-authored using generative AI tooling?
No.