Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-5958][MLLIB][DOC] update block matrix user guide #4737

Closed
wants to merge 1 commit into from
Closed

[SPARK-5958][MLLIB][DOC] update block matrix user guide #4737

wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Feb 24, 2015

  • Removed SVD code from examples.
  • Corrected Java API doc link.
  • Updated variable names: AtransposeA -> ata.
  • Minor changes.

@brkyvz

@SparkQA
Copy link

SparkQA commented Feb 24, 2015

Test build #27873 has started for PR 4737 at commit 70f53ac.

  • This patch merges cleanly.

@brkyvz
Copy link
Contributor

brkyvz commented Feb 24, 2015

LGTM. I thought it would be nice to show how people can go back to RowMatrix and call SVD after some operations, but we can keep it simple. I apologize for missing the Java API Doc link.

@mengxr
Copy link
Contributor Author

mengxr commented Feb 24, 2015

I removed the SVD example because it is not the "recommended" way of computing SVD of a block matrix and this user guide is for data types. We should add SVD implementations directly on top of block matrix later.

@SparkQA
Copy link

SparkQA commented Feb 24, 2015

Test build #27873 has finished for PR 4737 at commit 70f53ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27873/
Test PASSed.

asfgit pushed a commit that referenced this pull request Feb 24, 2015
@mengxr
[SPARK-5958][MLLIB][DOC] update block matrix user guide
dd42558 
* Removed SVD code from examples.
* Corrected Java API doc link.
* Updated variable names: `AtransposeA` -> `ata`.
* Minor changes.

brkyvz

Author: Xiangrui Meng <meng@databricks.com>

Closes #4737 from mengxr/update-block-matrix-user-guide and squashes the following commits:

70f53ac [Xiangrui Meng] update block matrix user guide

(cherry picked from commit cf2e416)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor Author

mengxr commented Feb 24, 2015

Merged into master and branch-1.3.

@asfgit asfgit closed this in cf2e416 Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengxr @SparkQA @brkyvz @AmplabJenkins