Skip to content

Conversation

wayneguow
Copy link
Contributor

What changes were proposed in this pull request?

This PR aims to upgrade tink from 1.13.0 to 1.14.1.

Why are the changes needed?

There are some bug fixes and performance improvements:
https://github.com/tink-crypto/tink-java/releases/tag/v1.14.0
Performance improvements

  • Improved performance of AES-EAX AEAD.
  • Improved performance of AES-SIV Deterministic AEAD.
  • Improved performance of AES-CMAC PRF.
  • Improved performance of ECIES Hybrid Encryption.

Bug fixes

  • Fixed bug in binary keyset parsing that resulted in a TinkBugException when parsing invalid input.
  • Fixed bug in JSON keyset parsing that resulted in a RuntimeException when parsing invalid input.
  • Fixed bug where the channel obtained from newSeekableDecryptingChannel falsely returned -1 on read calls. This only happens if read was called with an empty buffer, and if the previous call to read sucessfully read the end of the stream.

and downgraded protobuf to 25.3 to avoid incompatibility issues in v1.14.1.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Aug 6, 2024
@wayneguow wayneguow marked this pull request as ready for review August 7, 2024 02:08
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@yaooqinn yaooqinn closed this in d9f358f Aug 8, 2024
@yaooqinn
Copy link
Member

yaooqinn commented Aug 8, 2024

Merged to master. Thank you all.

attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade `tink` from 1.13.0 to 1.14.1.

### Why are the changes needed?

There are some bug fixes and performance improvements:
https://github.com/tink-crypto/tink-java/releases/tag/v1.14.0
Performance improvements
- Improved performance of AES-EAX AEAD.
- Improved performance of AES-SIV Deterministic AEAD.
- Improved performance of AES-CMAC PRF.
- Improved performance of ECIES Hybrid Encryption.

Bug fixes
- Fixed bug in binary keyset parsing that resulted in a TinkBugException when parsing invalid input.
- Fixed bug in JSON keyset parsing that resulted in a RuntimeException when parsing invalid input.
- Fixed bug where the channel obtained from newSeekableDecryptingChannel falsely returned -1 on read calls. This only happens if read was called with an empty buffer, and if the previous call to read sucessfully read the end of the stream.

and downgraded `protobuf` to 25.3 to avoid incompatibility issues in v1.14.1.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47632 from wayneguow/tink.

Authored-by: Wei Guo <guow93@gmail.com>
Signed-off-by: Kent Yao <yao@apache.org>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade `tink` from 1.13.0 to 1.14.1.

### Why are the changes needed?

There are some bug fixes and performance improvements:
https://github.com/tink-crypto/tink-java/releases/tag/v1.14.0
Performance improvements
- Improved performance of AES-EAX AEAD.
- Improved performance of AES-SIV Deterministic AEAD.
- Improved performance of AES-CMAC PRF.
- Improved performance of ECIES Hybrid Encryption.

Bug fixes
- Fixed bug in binary keyset parsing that resulted in a TinkBugException when parsing invalid input.
- Fixed bug in JSON keyset parsing that resulted in a RuntimeException when parsing invalid input.
- Fixed bug where the channel obtained from newSeekableDecryptingChannel falsely returned -1 on read calls. This only happens if read was called with an empty buffer, and if the previous call to read sucessfully read the end of the stream.

and downgraded `protobuf` to 25.3 to avoid incompatibility issues in v1.14.1.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47632 from wayneguow/tink.

Authored-by: Wei Guo <guow93@gmail.com>
Signed-off-by: Kent Yao <yao@apache.org>
@wayneguow wayneguow deleted the tink branch February 11, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants