[SPARK-49022][CONNECT][SQL][FOLLOW-UP] Parse unresolved identifier to keep the behavior same #48376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hvanhovell |
HyukjinKwon
force-pushed
the
SPARK-49022-followup
branch
from
4e6ccd9 to
b27c4c1
Compare
hvanhovell
reviewed
Oct 8, 2024
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Oct 8, 2024
...ctor/connect/client/jvm/src/main/scala/org/apache/spark/sql/internal/columnNodeSupport.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Oct 8, 2024
|
|
||
| case UnresolvedRegex(unparsedIdentifier, planId, _) => | ||
| convertUnresolvedAttribute(unparsedIdentifier, planId, isMetadataColumn = false) | ||
| convertUnresolvedRegex(unparsedIdentifier, planId) |
There was a problem hiding this comment.
This seems a bit inconsistent with unresolved attributes. Is this observable?
There was a problem hiding this comment.
I think it's fine in a way that it's consistent with catalyst ..
HyukjinKwon
force-pushed
the
SPARK-49022-followup
branch
from
a05df9b to
8e586a5
Compare
HyukjinKwon
force-pushed
the
SPARK-49022-followup
branch
from
f4580b8 to
2ad70f4
Compare
|
Let me merge this @hvanhovell please let me know if there are some more things to change, I will make another PR. |
|
Merged to master. |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
… keep the behavior same ### What changes were proposed in this pull request? This PR is a followup of apache#47688 that keeps `Column.toString` as the same before. ### Why are the changes needed? To keep the same behaviour with Spark Classic and Connect. ### Does this PR introduce _any_ user-facing change? No, the main change has not been released out yet. ### How was this patch tested? Will be added separately. I manually tested: ```scala import org.apache.spark.sql.functions.col val name = "with`!#$%dot".replace("`", "``") col(s"`${name}`").toString.equals("with`!#$%dot") ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48376 from HyukjinKwon/SPARK-49022-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #47688 that keeps
Column.toStringas the same before.Why are the changes needed?
To keep the same behaviour with Spark Classic and Connect.
Does this PR introduce any user-facing change?
No, the main change has not been released out yet.
How was this patch tested?
Will be added separately. I manually tested:
Was this patch authored or co-authored using generative AI tooling?
No.