[SPARK-50066][SQL] Codegen Support for SchemaOfXml (by Invoke & RuntimeReplaceable)
#48594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timeReplaceable)
MaxGekk
reviewed
Nov 13, 2024
| import org.apache.spark.sql.types.{ArrayType, DataType, StructType} | ||
| import org.apache.spark.unsafe.types.UTF8String | ||
|
|
||
| case class SchemaOfXmlEvaluator(options: Map[String, String]) { |
There was a problem hiding this comment.
How about to place it inside of a XmlExpressionEvalUtils object as you did for JSON expressions in JsonExpressionEvalUtils?
There was a problem hiding this comment.
Yeah, updated. Thanks!
MaxGekk
approved these changes
Nov 13, 2024
|
+1, LGTM. Merging to master. |
|
Thank you, @panbingkun and @MaxGekk . |
|
Thank all, @MaxGekk and @dongjoon-hyun ❤️ |
cloud-fan
reviewed
Nov 27, 2024
| dataType, | ||
| "schemaOfXml", | ||
| Seq(Literal(xmlInferSchema, xmlInferSchemaObjectType), child), | ||
| Seq(xmlInferSchemaObjectType, child.dataType) |
There was a problem hiding this comment.
we should set returnNullable to false, otherwise it's a regression. SchemaOfXml#nullable always return false.
cc @panbingkun
There was a problem hiding this comment.
Okay, I have fixed this issue with followup #48987. I think scheme_of_xml, schema_of_csv and schema_of_json has similar issues, so I will fix them all at once.
Thanks!
cloud-fan
pushed a commit
that referenced
this pull request
Nov 28, 2024
…lable as false ### What changes were proposed in this pull request? The pr is following up [schema_of_json](#48473), [schema_of_xml](#48594) and [schema_of_csv](#48595), to make returnNullable as false. ### Why are the changes needed? As `cloud-fan`'s comment https://github.com/apache/spark/pull/48594/files#r1860534460, we should follow the original logic, otherwise it's a regression. https://github.com/apache/spark/blob/1a502d32ef5a69739e10b827be4c9063b2a20493/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala#L846 https://github.com/apache/spark/blob/1a502d32ef5a69739e10b827be4c9063b2a20493/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xmlExpressions.scala#L166 https://github.com/apache/spark/blob/1a502d32ef5a69739e10b827be4c9063b2a20493/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala#L141 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48987 from panbingkun/SPARK-50066_FOLLOWUP. Authored-by: panbingkun <panbingkun@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to add
CodegenSupport forschema_of_xml.Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA & Existed UT (eg: XmlFunctionsSuite#
*schema_of_xml*)Was this patch authored or co-authored using generative AI tooling?
No.