[SPARK-49638][SQL] Remove the ANSI config suggestion in INVALID_URL #48616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mihailo Milosevic <mihailo.milosevic@databricks.com>
# Conflicts: # python/pyspark/sql/functions/builtin.py # python/pyspark/sql/tests/test_functions.py
MaxGekk
approved these changes
Oct 23, 2024
MaxGekk
changed the title
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the suggested fix of
INVALID_URLerror to usetry_parse_urlfunction added in this PR instead of turning off ANSI mode.Why are the changes needed?
INVALID_URL contains suggested fix for turning off ANSI mode. Now that in Spark 4.0.0 we have moved to ANSI mode on by default, we want to keep suggestions of this kind to the minimum. There exist implementations of try_* functions which provide safe way to get behavior as for ANSI mode off and suggestions of this kind should be sufficient.
In this case, try expressions were missing so new expressions were added to patch up the missing implementations.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
There are tests that check error messages.
Was this patch authored or co-authored using generative AI tooling?
No.