[SPARK-50031][SQL][FOLLOW-UP] Add tests for try_parse_url in the connect module
#48637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
Oct 24, 2024
There was a problem hiding this comment.
I think the primary purpose of this PR is to add tests for the try_parse_url function in the connect module, rather than to supplement golden files. If there are no new tests added, the corresponding golden files are not needed. So, please revise the pr title. @jovanm-db Thanks
jovanm-db
changed the title
MaxGekk
approved these changes
Oct 25, 2024
MaxGekk
changed the title
try_parse_url in the connect module
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add tests in
PlanGenerationTestSuitefortry_parse_urlfunction introduced in this PR and generate the corresponding golden files.Why are the changes needed?
The added tests ensure the new function behaves as expected.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tests added.
Was this patch authored or co-authored using generative AI tooling?
No.