[SPARK-50116][SQL] Assign appropriate error condition for _LEGACY_ERROR_TEMP_2067: UNSUPPORTED_PARTITION_TRANSFORM
#48655
Conversation
…OR_TEMP_2067: UNSUPPORTED_PARTITION_TRANSFORM
| errorClass = "_LEGACY_ERROR_TEMP_2067", | ||
| messageParameters = Map("transform" -> transform.toString())) | ||
| errorClass = "UNSUPPORTED_PARTITION_TRANSFORM", | ||
| messageParameters = Map("transform" -> toSQLId(transform.toString))) |
There was a problem hiding this comment.
Isn't transform an expression actually. If so, please, use toSQLExpr
There was a problem hiding this comment.
I tried it but unfortunately it says Transform is not an Expression:
Is there happen to any way converting Transform to Expression?
There was a problem hiding this comment.
ah, I see. Transform extends another Expression from org.apache.spark.sql.connector.expressions. Could you add one more definition of toSQLExpr which accept connector.expressions.Expression. It should quote in the same way as the existing toSQLExpr (using quoteByDefault).
There was a problem hiding this comment.
Sure will add it. Thanks for the comment!
There was a problem hiding this comment.
Hi, @MaxGekk I just realized during addressing the comment that we also should add all internal functions such as toPrettySQL(e: Expression), usePrettyExpression(e: Expression), Expression.sql, transform, dataType, etc. that are used by quoteByDefault internally.
I believe the number of changes and complexity would not be very trivial so maybe we better open separate ticket and discuss there?
There was a problem hiding this comment.
I see. thank you for the investigation.
|
+1, LGTM. Merging to master. |
|
ah, the ticket SPARK-50016 is wrong. @itholic could provide a correct one. |
itholic
changed the title
_LEGACY_ERROR_TEMP_2067: UNSUPPORTED_PARTITION_TRANSFORM_LEGACY_ERROR_TEMP_2067: UNSUPPORTED_PARTITION_TRANSFORM
|
Oh, it should be SPARK-50116. Let me update the JIRA |
What changes were proposed in this pull request?
This PR proposes to assign proper error condition & sqlstate for
_LEGACY_ERROR_TEMP_2067:UNSUPPORTED_PARTITION_TRANSFORMWhy are the changes needed?
To improve the error message by assigning proper error condition and SQLSTATE
Does this PR introduce any user-facing change?
No, only user-facing error message improved
How was this patch tested?
Updated the existing tests
Was this patch authored or co-authored using generative AI tooling?
No