[SPARK-49696][SQL][TESTS] Disable flaky test Cancellation APIs in SparkSession are isolated
#48736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dongjoon-hyun Could you review this PR? |
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionJobTaggingAndCancellationSuite.scala
Show resolved
Hide resolved
dongjoon-hyun
requested changes
Nov 1, 2024
xupefei
changed the title
Cancellation APIs in SparkSession are isolatedCancellation APIs in SparkSession are isolated
xupefei
changed the title
Cancellation APIs in SparkSession are isolatedCancellation APIs in SparkSession are isolated
dongjoon-hyun
changed the title
Cancellation APIs in SparkSession are isolatedCancellation APIs in SparkSession are isolated
dongjoon-hyun
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
+1, LGTM (Pending CIs). I revised the PR title properly, @xupefei .
Please re-triggered the failed test pipeline.
|
Although we have still two failures, there are irrelevant to this test only PR . Let me merge this. Thank you, @xupefei . |
|
Merged to master. SPARK-49696 is assigned to you, @xupefei . 
|
Thank you. I'll work on that ticket. |
|
Oh, no~ The issue SPARK-49696 was assigned to you as a recognition of this PR. There is not thing for you to work with it further, @xupefei. :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR disables a flaky test
SparkSessionJobTaggingAndCancellationSuite.Cancellation APIs in SparkSession are isolated(failure example: https://github.com/apache/spark/actions/runs/10915451051/job/30295259985). The flakiness is caused by CI sometimes creating only 2 threads instead of the requested 3. We should refactor the test to use only 2 threads.I created https://issues.apache.org/jira/browse/SPARK-50205 to fix and re-enable this test case.
Why are the changes needed?
To keep the CI green.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A.
Was this patch authored or co-authored using generative AI tooling?
No.