[SPARK-50214][SQL] From json/xml should not change collations in the given schema #48750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Nov 4, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExprUtils.scala
Outdated
Show resolved
Hide resolved
MaxGekk
reviewed
Nov 4, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Nov 4, 2024
…onSQLFunctionsSuite.scala
MaxGekk
reviewed
Nov 4, 2024
There was a problem hiding this comment.
@stefankandic Could you fix the test failure as it is related to your changes:
[info] - function from_json *** FAILED *** (42 milliseconds)
[info] Expected and actual plans do not match:
MaxGekk
reviewed
Nov 5, 2024
Comment on lines
29
to
30
| val spark = this.spark | ||
| import spark.implicits._ |
There was a problem hiding this comment.
Maybe import testImplicits._ at the beginning of the class, see JsonFunctionsSuite.
|
I think the failed test is not related to the changes: +1, LGTM. Merging to master. |
MaxGekk
pushed a commit
that referenced
this pull request
Mar 11, 2025
… in the given schema" ### What changes were proposed in this pull request? After removing session-level collation (#49772) we can also revert the PR that changed the behavior of `from_json` and `from_xml` expressions to use json and not sql type representation under the hood (#48750). ### Why are the changes needed? Now that we don't have correctness problems with session level collation, using `sql` instead of `json` will lead to smaller and more efficient type representation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50234 from stefankandic/revertFromJsonChange. Authored-by: Stefan Kandic <stefan.kandic@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
MaxGekk
pushed a commit
that referenced
this pull request
Mar 11, 2025
… in the given schema" ### What changes were proposed in this pull request? After removing session-level collation (#49772) we can also revert the PR that changed the behavior of `from_json` and `from_xml` expressions to use json and not sql type representation under the hood (#48750). ### Why are the changes needed? Now that we don't have correctness problems with session level collation, using `sql` instead of `json` will lead to smaller and more efficient type representation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50234 from stefankandic/revertFromJsonChange. Authored-by: Stefan Kandic <stefan.kandic@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 0094f44) Signed-off-by: Max Gekk <max.gekk@gmail.com>
anoopj
pushed a commit
to anoopj/spark
that referenced
this pull request
Mar 15, 2025
… in the given schema" ### What changes were proposed in this pull request? After removing session-level collation (apache#49772) we can also revert the PR that changed the behavior of `from_json` and `from_xml` expressions to use json and not sql type representation under the hood (apache#48750). ### Why are the changes needed? Now that we don't have correctness problems with session level collation, using `sql` instead of `json` will lead to smaller and more efficient type representation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50234 from stefankandic/revertFromJsonChange. Authored-by: Stefan Kandic <stefan.kandic@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fix ensures that
from_jsonandfrom_xmlreturn the exact schema provided, even when session collation is set.Why are the changes needed?
When serializing schema with the
sqlmethod, parsing it back can yield a different schema if session collation is set. This fix maintains consistency in schema structure regardless of collation settings.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.