[SPARK-51259][SQL] Refactor natural and using join keys computation #50009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailotim-db
force-pushed
the
mihailotim-db/join_refactor
branch
4 times, most recently
from
f668314 to
9d86dc7
Compare
mihailotim-db
changed the title
mihailotim-db
changed the title
mihailotim-db
force-pushed
the
mihailotim-db/join_refactor
branch
from
9d86dc7 to
c1266e8
Compare
mihailotim-db
commented
Feb 19, 2025
Comment on lines
-3584
to
-3585
| val lUniqueOutput = left.output.filterNot(att => leftKeys.contains(att)) | ||
| val rUniqueOutput = right.output.filterNot(att => rightKeys.contains(att)) |
There was a problem hiding this comment.
I changed the return type of computeKeysForNaturalOrUsingJoin from Seq to AttributeSet to avoid quadratic lookups here. I think it makes sense to make this change in this PR, but it can be moved to a followup. Wdyt @cloud-fan @vladimirg-db ?
There was a problem hiding this comment.
Moved to a separate PR: #50010
mihailotim-db
force-pushed
the
mihailotim-db/join_refactor
branch
3 times, most recently
from
d0cafda to
5f74bc8
Compare
mihailotim-db
changed the title
mihailotim-db
force-pushed
the
mihailotim-db/join_refactor
branch
from
5f74bc8 to
fb354ed
Compare
cloud-fan
approved these changes
Feb 20, 2025
|
thanks, merging to master! |
Pajaraja
pushed a commit
to Pajaraja/spark
that referenced
this pull request
Mar 6, 2025
### What changes were proposed in this pull request? Refactor natural and using join key computation to a separate component so that it can be reused in single-pass resolver. ### Why are the changes needed? To reuse code in single-pass resolver. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50009 from mihailotim-db/mihailotim-db/join_refactor. Authored-by: Mihailo Timotic <mihailo.timotic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor natural and using join key computation to a separate component so that it can be reused in single-pass resolver.
Why are the changes needed?
To reuse code in single-pass resolver.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No