[SPARK-51378][CORE] Apply JsonProtocol's accumulableExcludeList to ExecutorMetricsUpdate and TaskEndReason #50141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lables in event logs
JoshRosen
changed the title
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Mar 4, 2025
|
Merged to master and branch-4.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 4, 2025
…ecutorMetricsUpdate and TaskEndReason ### What changes were proposed in this pull request? This PR updates `JsonProtocol` so that its `accumulableExcludeList` is considered when logging accumulable in TaskEndReasons and ExecutorMetricUpdate events. This exclusion list was originally added in #17412 and originally only applied to StageInfo and TaskInfo logging. ### Why are the changes needed? Reduce event log size and improve event logger throughput by avoiding the need to process possibly large / expensive accumulators. This gap for ExecutorMetricsUpdate was noted in a comment (#17412 (comment)); I recently rediscovered it in my own Spark usage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50141 from JoshRosen/apply-accumulableExcludeList-to-other-event-log-fields. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 62f7f14) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Pajaraja
pushed a commit
to Pajaraja/spark
that referenced
this pull request
Mar 6, 2025
…ecutorMetricsUpdate and TaskEndReason ### What changes were proposed in this pull request? This PR updates `JsonProtocol` so that its `accumulableExcludeList` is considered when logging accumulable in TaskEndReasons and ExecutorMetricUpdate events. This exclusion list was originally added in apache#17412 and originally only applied to StageInfo and TaskInfo logging. ### Why are the changes needed? Reduce event log size and improve event logger throughput by avoiding the need to process possibly large / expensive accumulators. This gap for ExecutorMetricsUpdate was noted in a comment (apache#17412 (comment)); I recently rediscovered it in my own Spark usage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50141 from JoshRosen/apply-accumulableExcludeList-to-other-event-log-fields. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
anoopj
pushed a commit
to anoopj/spark
that referenced
this pull request
Mar 15, 2025
…ecutorMetricsUpdate and TaskEndReason ### What changes were proposed in this pull request? This PR updates `JsonProtocol` so that its `accumulableExcludeList` is considered when logging accumulable in TaskEndReasons and ExecutorMetricUpdate events. This exclusion list was originally added in apache#17412 and originally only applied to StageInfo and TaskInfo logging. ### Why are the changes needed? Reduce event log size and improve event logger throughput by avoiding the need to process possibly large / expensive accumulators. This gap for ExecutorMetricsUpdate was noted in a comment (apache#17412 (comment)); I recently rediscovered it in my own Spark usage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50141 from JoshRosen/apply-accumulableExcludeList-to-other-event-log-fields. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates
JsonProtocolso that itsaccumulableExcludeListis considered when logging accumulable in TaskEndReasons and ExecutorMetricUpdate events.This exclusion list was originally added in #17412 and originally only applied to StageInfo and TaskInfo logging.
Why are the changes needed?
Reduce event log size and improve event logger throughput by avoiding the need to process possibly large / expensive accumulators.
This gap for ExecutorMetricsUpdate was noted in a comment (#17412 (comment)); I recently rediscovered it in my own Spark usage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.