[SPARK-51618][INFRA] Add a check to reject jars in CI #50416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 82f75fe.
|
cc @yaooqinn @hvanhovell @pan3793 this addresses your comments. |
dongjoon-hyun
approved these changes
Mar 27, 2025
yaooqinn
reviewed
Mar 27, 2025
|
Merged to master and branch-4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a check if the commits add/fix jars, and reject.
Why are the changes needed?
It is discouraged to have jars in the repo.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
l manually tested with the jar removal (82f75fe) and changing
dev/test-jars.txtand:It will fails as below:
Was this patch authored or co-authored using generative AI tooling?
No.