Skip to content

pyspark: Improve SparkConf typing #51100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

pyspark: Improve SparkConf typing #51100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5030aed
Improve SparkConf typing
grihabor Jun 5, 2025
4b8c2d6
Import from collections.abc instead
grihabor Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/pyspark/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
__all__ = ["SparkConf"]

import sys
from collections.abc import Iterable
from typing import Dict, List, Optional, Tuple, cast, overload, TYPE_CHECKING

from pyspark.util import is_remote_only
Expand Down Expand Up @@ -176,14 +177,14 @@ def setExecutorEnv(self, key: str, value: str) -> "SparkConf":
...

@overload
def setExecutorEnv(self, *, pairs: List[Tuple[str, str]]) -> "SparkConf":
def setExecutorEnv(self, *, pairs: Iterable[Tuple[str, str]]) -> "SparkConf":
...

def setExecutorEnv(
self,
key: Optional[str] = None,
value: Optional[str] = None,
pairs: Optional[List[Tuple[str, str]]] = None,
pairs: Optional[Iterable[Tuple[str, str]]] = None,
) -> "SparkConf":
"""Set an environment variable to be passed to executors."""
if (key is not None and pairs is not None) or (key is None and pairs is None):
Expand All @@ -198,7 +199,7 @@ def setExecutorEnv(
self.set("spark.executorEnv.{}".format(k), v)
return self

def setAll(self, pairs: List[Tuple[str, str]]) -> "SparkConf":
def setAll(self, pairs: Iterable[Tuple[str, str]]) -> "SparkConf":
"""
Set multiple parameters, passed as a list of key-value pairs.

Expand Down
Loading