Skip to content

[SPARK-53133][SQL][TESTS] Use Java System.getProperty instead of FileUtils.getTempDirectory #51858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-53133][SQL][TESTS] Use Java System.getProperty instead of FileUtils.getTempDirectory #51858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scalastyle-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@ This file is divided into 3 sections:
scala.jdk.CollectionConverters._ and use .asScala / .asJava methods</customMessage>
</check>

<check customId="getTempDirectory" level="error" class="org.scalastyle.file.RegexChecker" enabled="true">
<parameters><parameter name="regex">\bFileUtils\.getTempDirectory\b</parameter></parameters>
<customMessage>Use System.getProperty instead.</customMessage>
</check>

<check customId="readLines" level="error" class="org.scalastyle.file.RegexChecker" enabled="true">
<parameters><parameter name="regex">\bFileUtils\.readLines\b</parameter></parameters>
<customMessage>Use Files.readAllLines instead.</customMessage>
Expand Down
4 changes: 1 addition & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ import java.nio.file.Files

import scala.collection.mutable

import org.apache.commons.io.FileUtils

import org.apache.spark.sql.catalyst.expressions.AttributeSet
import org.apache.spark.sql.catalyst.util._
import org.apache.spark.sql.execution._
Expand Down Expand Up @@ -138,7 +136,7 @@ trait PlanStabilitySuite extends DisableAdaptiveExecutionSuite {

private def checkWithApproved(plan: SparkPlan, name: String, explain: String): Unit = {
val dir = getDirForTest(name)
val tempDir = FileUtils.getTempDirectory
val tempDir = System.getProperty("java.io.tmpdir")
val actualSimplified = getSimplifiedPlan(plan)
val foundMatch = isApproved(dir, actualSimplified, explain)

Expand Down