-
Notifications
You must be signed in to change notification settings - Fork 28.8k
[SPARK-6911] [SQL] improve accessor for nested types #5513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @rxin |
Test build #30268 has finished for PR 5513 at commit
|
Test build #668 has finished for PR 5513 at commit
|
Test build #673 has started for PR 5513 at commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we create two versions: one for string, and one for int?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key of MapType could be any type (for example, DateType), so it should be Any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GetItem
operation is designed for both array and map. But to make the name consistent with GetItem, I think we should keep the name but only change the type to Any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense. @davies can you add a unit test to scala? in ColumnExpressionSuite or DataFrameSuite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Test build #671 has finished for PR 5513 at commit
|
Test build #30325 has finished for PR 5513 at commit
|
Test build #30360 has finished for PR 5513 at commit
|
Test build #679 has started for PR 5513 at commit |
LGTM cc @marmbrus |
Test build #30379 timed out for PR 5513 at commit |
@JoshRosen Could you change the timeout to 180 minutes? |
Test build #682 timed out for PR 5513 at commit |
Test build #683 has started for PR 5513 at commit |
Jenkins, test this please. |
Test build #30402 timed out for PR 5513 at commit |
@davies The Jenkins plugin's timeout is already configured to 180 minutes; I think you'll need to update the |
By the way, the timeout in the bash script should be less than the timeout that we've configured in Jenkins. If it's not, then Jenkins' timer will fire first and prevent our script from posting useful timeout messages to GitHub (in that case, we'd only get the build abort message from AMPLab Jenkins). |
@JoshRosen Changed to 150m. |
Test build #30421 has finished for PR 5513 at commit
|
@marmbrus I think this PR is ready to go. |
Test build #30424 has finished for PR 5513 at commit
|
Thanks! Merged to master. |
Support access columns by index in Python:
Access items in ArrayType or MapType
Access field in StructType