Skip to content

Conversation

kanzhang
Copy link
Contributor

Not sure if this is the right thing to do, just in case it was overlooked.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pwendell
Copy link
Contributor

@kanzhang ah I see - I think this probably should remain as-is if it's code from another project. I thought you meant there was no license on this file.

@kanzhang
Copy link
Contributor Author

@pwendell I'm no expert on this, do as you see fit (I'm still a little surprised - I thought you give up your copyright when you upload your patch to Apache).

@srowen
Copy link
Member

srowen commented Apr 30, 2014

No Apache does not take over copyright in contributions, IIUC. Contributors own their contributions. In this case, was this code 'contributed' by the owner (Douban?) to begin with? or just added to the code base? If the latter, it can still be reused, if the license is compatible (and it looks so) but if the author didn't specifically agree to license differently, you can't decide that for them. Leave the license unless it's clear that this was contributed by the copyright owner under AL2.

@pwendell
Copy link
Contributor

@kanzhang I'm no expert either unfortunately :P. I do think in general we ask (maybe require) authors to sign over copyright to Apache when they contribute.

I think this code might be a somewhat abnormal case, I noticed @JoshRosen actually added this code (from UCB) in the original pyspark commit. I suspect the reason is that he was borrowing source code from an existing library and pulled in the corresponding license. In the case where pull in source code from other libraries I believe this is the correct thing to do.

@kanzhang
Copy link
Contributor Author

kanzhang commented May 2, 2014

Close as invalid.

@kanzhang kanzhang closed this May 2, 2014
@kanzhang kanzhang deleted the fix-license branch May 9, 2014 04:16
pwendell pushed a commit to pwendell/spark that referenced this pull request May 12, 2014
SPARK-1088: Create a script for running tests so we can have version specific testing on Jenkins.

@pwendell

Author: Reynold Xin <rxin@apache.org>

Closes apache#592 and squashes the following commits:

be02359 [Reynold Xin] SPARK-1088: Create a script for running tests so we can have version specific testing on Jenkins.
andrewor14 pushed a commit to andrewor14/spark that referenced this pull request Jan 8, 2015
…specific testing on Jenkins (branch-0.9)

This is for branch-0.9.

apache#592 is for master branch (1.0).

Author: Reynold Xin <rxin@apache.org>

Closes apache#593 from rxin/test-0.9 and squashes the following commits:

85a3aa0 [Reynold Xin] SPARK-1088: Create a script for running tests so we can have version specific testing on Jenkins.
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
Put all nodeset define together so that Openlab operator can
check all nodepool labels in zuul file nodesets.yaml.

Related-Bug: theopenlab/openlab#256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants