-
Notifications
You must be signed in to change notification settings - Fork 28.9k
fix Apache License for join.py #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
@kanzhang ah I see - I think this probably should remain as-is if it's code from another project. I thought you meant there was no license on this file. |
@pwendell I'm no expert on this, do as you see fit (I'm still a little surprised - I thought you give up your copyright when you upload your patch to Apache). |
No Apache does not take over copyright in contributions, IIUC. Contributors own their contributions. In this case, was this code 'contributed' by the owner (Douban?) to begin with? or just added to the code base? If the latter, it can still be reused, if the license is compatible (and it looks so) but if the author didn't specifically agree to license differently, you can't decide that for them. Leave the license unless it's clear that this was contributed by the copyright owner under AL2. |
@kanzhang I'm no expert either unfortunately :P. I do think in general we ask (maybe require) authors to sign over copyright to Apache when they contribute. I think this code might be a somewhat abnormal case, I noticed @JoshRosen actually added this code (from UCB) in the original pyspark commit. I suspect the reason is that he was borrowing source code from an existing library and pulled in the corresponding license. In the case where pull in source code from other libraries I believe this is the correct thing to do. |
Close as invalid. |
SPARK-1088: Create a script for running tests so we can have version specific testing on Jenkins. @pwendell Author: Reynold Xin <rxin@apache.org> Closes apache#592 and squashes the following commits: be02359 [Reynold Xin] SPARK-1088: Create a script for running tests so we can have version specific testing on Jenkins.
…specific testing on Jenkins (branch-0.9) This is for branch-0.9. apache#592 is for master branch (1.0). Author: Reynold Xin <rxin@apache.org> Closes apache#593 from rxin/test-0.9 and squashes the following commits: 85a3aa0 [Reynold Xin] SPARK-1088: Create a script for running tests so we can have version specific testing on Jenkins.
Put all nodeset define together so that Openlab operator can check all nodepool labels in zuul file nodesets.yaml. Related-Bug: theopenlab/openlab#256
Not sure if this is the right thing to do, just in case it was overlooked.