Skip to content

Conversation

viirya
Copy link
Member

@viirya viirya commented May 12, 2015

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32490 has finished for PR 6078 at commit 032d32c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented May 12, 2015

retest this please.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32498 has finished for PR 6078 at commit 032d32c.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StringVectorizer extends Estimator[StringVectorizerModel] with StringVectorizerBase

@viirya
Copy link
Member Author

viirya commented May 12, 2015

retest this please.

@SparkQA
Copy link

SparkQA commented May 12, 2015

Test build #32502 has finished for PR 6078 at commit 032d32c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StringVectorizer extends Estimator[StringVectorizerModel] with StringVectorizerBase

@mengxr
Copy link
Contributor

mengxr commented May 12, 2015

@viirya This is essentially StringIndexer + OneHotEncoder. So any ideas about code reuse?

@viirya
Copy link
Member Author

viirya commented May 13, 2015

@mengxr Updated.
But by reusing StringIndexer and OneHotEncoder, we introduce an intermediate column for StringIndexer's output. Now I use _ + outputColumnName as its column name. It is very rare, but still possibly conflicting with dataset's columns.

@SparkQA
Copy link

SparkQA commented May 13, 2015

Test build #32575 has finished for PR 6078 at commit 6eaee99.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StringVectorizer extends Estimator[StringVectorizerModel] with StringVectorizerBase

@viirya viirya closed this Aug 11, 2015
@viirya viirya deleted the stringvectorizer branch December 27, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants