Skip to content

[CORE] [SPARK-9760] Use Option instead of Some for Ivy repos #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[CORE] [SPARK-9760] Use Option instead of Some for Ivy repos #8055

wants to merge 3 commits into from

Conversation

shivaram
Copy link
Contributor

@shivaram shivaram commented Aug 9, 2015

This was introduced in #7599

cc @rxin @brkyvz

@shivaram
Copy link
Contributor Author

shivaram commented Aug 9, 2015

Also I am not sure how to add a test case for this as our existing unit tests use a custom Ivy repository which is always specified in --repositories. The bug only happens when --repositories is not specified

@rxin
Copy link
Contributor

rxin commented Aug 9, 2015

LGTM - @brkyvz this is why our coding style wants Option instead of Some!

@brkyvz
Copy link
Contributor

brkyvz commented Aug 9, 2015

Sorry for introducing this. A way to test this is to not provide a repository, and use a fake coordinate so that it fails with a RuntimeException, and not a NullPointerException.

@shivaram
Copy link
Contributor Author

shivaram commented Aug 9, 2015

Added a test case but I'm not sure how useful it is as a lot of things can throw a RuntimeException ? @rxin let me know if its worth having it vs. a few seconds added to the test suites.

@brkyvz
Copy link
Contributor

brkyvz commented Aug 9, 2015

I see why SparkSubmitUtilsSuite didn't catch this. I think I use either Some(repo) or none. Never Some(null). I thought we could add it to SparkSubmitUtilsSuite and use the intercept, not in an end to end SparkSubmitSuite test... May be you can add a comment on the line and say that they should remain as Options? I don't think the test is very useful in the current setup

@SparkQA
Copy link

SparkQA commented Aug 9, 2015

Test build #40255 has finished for PR 8055 at commit c02e0b4.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait DataSourceRegister

@SparkQA
Copy link

SparkQA commented Aug 9, 2015

Test build #40257 has finished for PR 8055 at commit 51d69ee.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@brkyvz
Copy link
Contributor

brkyvz commented Aug 9, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Aug 9, 2015

Test build #40260 has finished for PR 8055 at commit 51d69ee.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor Author

shivaram commented Aug 9, 2015

Jenkins, retest this please

@shivaram
Copy link
Contributor Author

shivaram commented Aug 9, 2015

@brkyvz Removed the test case now. I'm not sure adding a comment is really relevant as the argument to the method is an Option. And you are right that we can't quite test this in SparkSubmitUtilsSuite as passing None wouldn't trigger the bug.

@SparkQA
Copy link

SparkQA commented Aug 9, 2015

Test build #40273 has finished for PR 8055 at commit 51d69ee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Aug 9, 2015

Merging this - thanks.

asfgit pushed a commit that referenced this pull request Aug 9, 2015
@shivaram @rxin
[CORE] [SPARK-9760] Use Option instead of Some for Ivy repos
0e0471d 
This was introduced in #7599

cc rxin brkyvz

Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu>

Closes #8055 from shivaram/spark-packages-repo-fix and squashes the following commits:

890f306 [Shivaram Venkataraman] Remove test case
51d69ee [Shivaram Venkataraman] Add test case for --packages without --repository
c02e0b4 [Shivaram Venkataraman] Use Option instead of Some for Ivy repos

(cherry picked from commit 4602561)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 4602561 Aug 9, 2015
@brkyvz
Copy link
Contributor

brkyvz commented Aug 9, 2015

Hallelujah! Finally

@SparkQA
Copy link

SparkQA commented Aug 9, 2015

Test build #40274 has finished for PR 8055 at commit 890f306.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

CodingCat pushed a commit to CodingCat/spark that referenced this pull request Aug 17, 2015
@shivaram @CodingCat
[CORE] [SPARK-9760] Use Option instead of Some for Ivy repos
90cc379 
This was introduced in apache#7599

cc rxin brkyvz

Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu>

Closes apache#8055 from shivaram/spark-packages-repo-fix and squashes the following commits:

890f306 [Shivaram Venkataraman] Remove test case
51d69ee [Shivaram Venkataraman] Add test case for --packages without --repository
c02e0b4 [Shivaram Venkataraman] Use Option instead of Some for Ivy repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shivaram @rxin @brkyvz @SparkQA