Skip to content

Conversation

hhbyyh
Copy link
Contributor

@hhbyyh hhbyyh commented Sep 8, 2015

jira: https://issues.apache.org/jira/browse/SPARK-10482

Add Python interface for feature transformer: ml.CountVectorizer

@SparkQA
Copy link

SparkQA commented Sep 8, 2015

Test build #42112 has finished for PR 8650 at commit 0f1fa34.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 8, 2015

Test build #42122 has finished for PR 8650 at commit d22ba5a.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 8, 2015

Test build #42125 has finished for PR 8650 at commit dd0e933.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class CountVectorizer(JavaEstimator, HasInputCol, HasOutputCol):
    • class CountVectorizerModel(JavaModel):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove sentenceData =

@mengxr
Copy link
Contributor

mengxr commented Sep 8, 2015

LGTM except some minor issues

@holdenk
Copy link
Contributor

holdenk commented Sep 8, 2015

This seems to do the same work as the outstanding PR #8561

@mengxr
Copy link
Contributor

mengxr commented Sep 8, 2015

@holdenk Yes, I just noticed it. Could you merge some changes in this PR into yours? I think the doctest from @hhbyyh is better and the default values are specified correctly in this PR. I will make a pass after.

@hhbyyh Since this duplicates #8561, do you mind closing this PR? You can check opening PRs at https://spark-prs.appspot.com/#mllib.

@holdenk
Copy link
Contributor

holdenk commented Sep 8, 2015

Ok, I'll merge in the doc tests.

@hhbyyh hhbyyh closed this Sep 9, 2015
@hhbyyh
Copy link
Contributor Author

hhbyyh commented Sep 9, 2015

@mengxr Sorry for the extra effort during review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants