[SPARK-8029] robust shuffle writer (for 1.5 branch) #9686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davies
changed the title
|
cc @andrewor14 |
|
Test build #45841 timed out for PR 9686 at commit |
|
Test build #45847 has finished for PR 9686 at commit
|
|
retest this please |
|
Test build #45865 has finished for PR 9686 at commit
|
|
retest this please |
|
Test build #45873 has finished for PR 9686 at commit
|
|
merged into 1.5 |
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2015
Currently, all the shuffle writer will write to target path directly, the file could be corrupted by other attempt of the same partition on the same executor. They should write to temporary file then rename to target path, as what we do in output committer. In order to make the rename atomic, the temporary file should be created in the same local directory (FileSystem). This PR is based on #9214 , thanks to squito Author: Davies Liu <davies@databricks.com> Closes #9686 from davies/writer_1.5 and squashes the following commits: e95fcf5 [Davies Liu] fix test a6d569e [Davies Liu] fix consolidate 7e83298 [Davies Liu] robust shuffle writer
|
Test build #45879 has finished for PR 9686 at commit
|
|
@davies can you close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all the shuffle writer will write to target path directly, the file could be corrupted by other attempt of the same partition on the same executor. They should write to temporary file then rename to target path, as what we do in output committer. In order to make the rename atomic, the temporary file should be created in the same local directory (FileSystem).
This PR is based on #9214 , thanks to @squito