Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORM-2098: DruidBeamBolt: Pass DruidConfig.Builder as constructor argument #1688

Merged
merged 1 commit into from
Sep 19, 2016
Merged

STORM-2098: DruidBeamBolt: Pass DruidConfig.Builder as constructor argument #1688

merged 1 commit into from
Sep 19, 2016

Conversation

omkreddy
Copy link
Contributor

No description provided.

satishd
satishd approved these changes Sep 19, 2016
View reviewed changes
Copy link
Member

@satishd satishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, These changes are already pushed to master at #1686

@HeartSaVioR
Copy link
Contributor

AFAIK, 24hr policy and vote requirement is not in effect if it's for porting to other branches.
(If there're huge merge conflict you may want to treat PR as normal PR and having reviews.)

You don't need to wait for that, and you can also port back (and forth) while merging PR for master branch or so.

@asfgit asfgit merged commit 8a0776d into apache:1.x-branch Sep 19, 2016
@satishd
Copy link
Member

satishd commented Sep 19, 2016

Thanks @omkreddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satishd satishd satishd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omkreddy @HeartSaVioR @satishd @asfgit