Security: exclude Object's class methods #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
|
Since the ExcludePatternChecker already logs the value and the matched pattern being excluded, I don't think we should repeat that logging again by the caller... or at least trim down the caller's logging to just say something has been excluded (cause the callee is already logging that detail). |
Also all patterns are by default case insensitive
kusalk
added a commit
that referenced
this pull request
Oct 4, 2023
Merge in BAM/struts2-atlassian from issue/CONFSRVDEV-25415-allow-forwards to STRUTS_2_5_30-atlassian * commit 'aa264376c2cf2ff591927a50988517aab7691939': CONFSRVDEV-25415 Fix infinite forward loop CONFSRVDEV-25415 Allow forwarding to Struts actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is a follow up of the latest security issues discovered with
ParametersInterceptorto allow access object'sgetClassmethod via http request. This also solves problem accessing the same properties viamethod:prefix - it is blocked on OGNL level.