chore: update roles description

apache · Apr 13, 2021 · 573ed3e · 573ed3e
1 parent c932220
commit 573ed3e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/superset-frontend/src/dashboard/components/PropertiesModal/index.jsx b/superset-frontend/src/dashboard/components/PropertiesModal/index.jsx
@@ -399,7 +399,7 @@ class PropertiesModal extends React.PureComponent {
             />
             <p className="help-block">
               {t(
-                'Roles is a list which defines access to the dashboard. These roles are always applied in addition to restrictions on dataset level access. If no roles defined then the dashboard is available to all roles.',
+                'Roles is a list which defines access to the dashboard. Granting a role access to a dashboard will bypass dataset level checks. If no roles defined then the dashboard is available to all roles.',
               )}
             </p>
           </Col>

diff --git a/superset/views/dashboard/mixin.py b/superset/views/dashboard/mixin.py
@@ -65,8 +65,7 @@ class DashboardMixin:  # pylint: disable=too-few-public-methods
         "owners": _("Owners is a list of users who can alter the dashboard."),
         "roles": _(
             "Roles is a list which defines access to the dashboard. "
-            "These roles are always applied in addition to restrictions on dataset "
-            "level access. "
+            "Granting a role access to a dashboard will bypass dataset level checks."
             "If no roles defined then the dashboard is available to all roles."
         ),
         "published": _(
-Original file line number
+Diff line change
@@ Expand Up / @@ -399,7 +399,7 @@ class PropertiesModal extends React.PureComponent { @@
                 />
                 <p className="help-block">
                   {t(
-                    'Roles is a list which defines access to the dashboard. These roles are always applied in addition to restrictions on dataset level access. If no roles defined then the dashboard is available to all roles.',
+                    'Roles is a list which defines access to the dashboard. Granting a role access to a dashboard will bypass dataset level checks. If no roles defined then the dashboard is available to all roles.',
                   )}
                 </p>
               </Col>
@@ Expand Down @@