chore(sql_parse): Strip leading/trailing whitespace in Jinja macro ex…

…traction (#27842)
apache · Apr 3, 2024 · 5ab95aa · 5ab95aa
1 parent 1c742f5
commit 5ab95aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/superset/sql_parse.py b/superset/sql_parse.py
@@ -1548,7 +1548,7 @@ def extract_tables_from_jinja_sql(sql: str, database: Database) -> set[Table]:
             tables.add(
                 Table(
                     *[
-                        remove_quotes(part)
+                        remove_quotes(part.strip())
                         for part in node.args[0].value.split(".")[::-1]
                         if len(node.args) == 1
                     ]

diff --git a/tests/unit_tests/sql_parse_tests.py b/tests/unit_tests/sql_parse_tests.py
@@ -1937,6 +1937,7 @@ def test_sqlstatement() -> None:
     "macro",
     [
         "latest_partition('foo.bar')",
+        "latest_partition(' foo.bar ')",  # Non-atypical user error which works
         "latest_sub_partition('foo.bar', baz='qux')",
     ],
 )