Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests errors and warnings - iteration 4 (#12212) #12223

Merged
merged 1 commit into from
Jan 26, 2021
Merged

fix: tests errors and warnings - iteration 4 (#12212) #12223

merged 1 commit into from
Jan 26, 2021

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Dec 29, 2020 •
edited
Loading

SUMMARY

Remove tests errors and warnings to improve results readability.

The following errors and warnings have been removed:

Warning: Failed prop type: The prop `refreshFrequency` is marked as required, 
but its value is `undefined`.

spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx

Warning: validateDOMNesting(...): <tr> cannot appear as a child of <div>.

spec/javascripts/components/AlteredSliceTag_spec.jsx

When testing, code that causes React state updates should be wrapped into act(...)

spec/javascripts/components/ConfirmStatusChange_spec.jsx
spec/javascripts/components/ListView/ListView_spec.jsx

Unmatched <HTTP_METHOD> to <URL>

spec/javascripts/components/SupersetResourceSelect_spec.tsx
spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx

Warning: Failed prop type: The prop `setMountedTab` is marked as required, 
but its value is `undefined`.

spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx

Warning: Failed prop type: The prop `isComponentVisible` is marked as required in 
`DashboardGrid`, but its value is `undefined`.

spec/javascripts/dashboard/components/DashboardGrid_spec.jsx

Warning: Failed prop type: The prop `setDirectPathToChild` is marked as required in 
`DashboardGrid`, but its value is `undefined`.

spec/javascripts/dashboard/components/DashboardGrid_spec.jsx

Warning: Failed prop type: The prop `slice` is marked as required, but its value is `undefined`.

spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx

Warning: Failed prop type: You have provided a `open` prop to `Dropdown` 
without an `onToggle` handler prop. This will render a read-only field. 
If the field should be mutable use `defaultOpen`. Otherwise, set `onToggle`.

src/components/Menu/LanguagePicker.tsx

#12212

@rusackas @junlincc @villebro

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas added the hold! On hold label Jan 6, 2021
@michael-s-molina michael-s-molina force-pushed the fix-tests-errors-warnings-4 branch 2 times, most recently from 147954d to eb009e4 Compare January 20, 2021 16:32
@codecov-io
Copy link

codecov-io commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #12223 (25997e3) into master (5504762) will decrease coverage by 1.78%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12223      +/-   ##
==========================================
- Coverage   64.55%   62.77%   -1.79%     
==========================================
  Files        1018     1018              
  Lines       49787    49775      -12     
  Branches     4971     4877      -94     
==========================================
- Hits        32141    31246     -895     
- Misses      17468    18329     +861     
- Partials      178      200      +22
Flag Coverage Δ
cypress ?
javascript 61.40% <0.00%> (+0.45%) ⬆️
python 63.67% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/Menu/LanguagePicker.tsx 64.28% <0.00%> (-4.95%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/filters/components/Select/types.ts 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-93.34%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-77.78%) ⬇️
superset-frontend/src/setup/setupFormatters.ts 0.00% <0.00%> (-75.00%) ⬇️
...c/visualizations/FilterBox/FilterBoxChartPlugin.js 0.00% <0.00%> (-75.00%) ⬇️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5504762...25997e3. Read the comment docs.

@michael-s-molina michael-s-molina force-pushed the fix-tests-errors-warnings-4 branch 2 times, most recently from 2db2819 to 9d79acf Compare January 22, 2021 11:17
@rusackas rusackas removed the hold! On hold label Jan 25, 2021
rusackas
rusackas approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! BTW, thank you for the great issue description for all of these! It really helps parsing the rationale behind the code I'm looking at.

@rusackas rusackas merged commit 0c08bb8 into apache:master Jan 26, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 26, 2021
Merge branch 'master' into feat/dashboard_access_roles
1d3e3ae 
* master: (52 commits)
  docs: Updates to Superset Site for 1.0 (apache#12626)
  test(native-filters): scoping tree in native filters modal (apache#12655)
  Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219)
  Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224)
  Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227)
  feat(native-filters): apply scoping of native filters to dashboard (apache#12716)
  Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223)
  Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245)
  fix: missing select menu background (apache#12759)
  fix(explore): incorrect missing datasource condition (apache#12758)
  feat: default timepicker to last week when dataset is changed (apache#12609)
  feat(explore): allow opening charts with missing dataset (apache#12705)
  chore: upgrade Cypress to 6.2.1 (apache#12605)
  refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218)
  feat: Adding option to set_database_uri CLI command (apache#12740)
  docs: Fixed typo on line 348 (apache#12739)
  Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214)
  docs: Remove gatsby-plugin-offline (apache#12693)
  test: oracle engine spec (apache#12615)
  test: hive db engine spec (apache#12520)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-s-molina @codecov-io @rusackas @junlincc