chore: upgrade Cypress to 6.2.1 #12605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12605 +/- ##
==========================================
- Coverage 66.83% 66.68% -0.16%
==========================================
Files 1022 1022
Lines 49994 49994
Branches 4892 5023 +131
==========================================
- Hits 33412 33336 -76
- Misses 16457 16533 +76
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
upgrade-cypress
branch
3 times, most recently
from
ded2f44
to
fc12c74
Compare
ktmud
force-pushed
the
upgrade-cypress
branch
from
1e537b2
to
d74eb6b
Compare
ktmud
force-pushed
the
upgrade-cypress
branch
from
f9e9117
to
f3d642a
Compare
ktmud
commented
Jan 22, 2021
| @@ -98,7 +100,7 @@ describe('Visualization > Table', () => { | |||
| }); | |||
| cy.verifySliceSuccess({ | |||
| waitAlias: '@getJson', | |||
| querySubstring: /groupby.*name/, | |||
| querySubstring: /group by.*name/i, | |||
There was a problem hiding this comment.
Previously this check also fails, but it doesn't report as an error.
villebro
approved these changes
Jan 23, 2021
Comment on lines
-180
to
+149
| op: 'IN', | ||
| val: ['South Asia'], | ||
| op: '==', | ||
| val: 'South Asia', |
There was a problem hiding this comment.
I'm surprised this (and the others below) even worked before?
There was a problem hiding this comment.
I think previously Cypress will just let this expect check in wait.then(...) pass even if it fails.
ktmud
force-pushed
the
upgrade-cypress
branch
from
43850fa
to
06895a4
Compare
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jan 26, 2021
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Upgrade Cypress to 6.2.1 with some required refactoring:
readResponseBlobsince the newcy.intercept(..)API already reads JSON responses automatically.verifyResponseCodessince it's very unlikely that we get an incorrect status code yet still receive the correct response.FormDataparser sincerequest.bodyis no longer a nativeFormDataobject.should('not.visible')to.should('not.exist')because Cypress will now throw errors for elements that do not exist.Upgrading since I wanted to add more tests for time-series table and box plot viz.
Reference: Cypress's official migration guide
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI must pass
ADDITIONAL INFORMATION