Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: oracle engine spec #12615

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Conversation

kstrz
Copy link
Contributor

@kstrz kstrz commented Jan 20, 2021

SUMMARY

Increase coverage for oracle db engine spec

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #12615 (6d1bf41) into master (a422c76) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12615      +/-   ##
==========================================
- Coverage   66.79%   66.67%   -0.13%     
==========================================
  Files        1015     1018       +3     
  Lines       49676    49793     +117     
  Branches     4847     4877      +30     
==========================================
+ Hits        33183    33197      +14     
- Misses      16371    16473     +102     
- Partials      122      123       +1     
Flag Coverage Δ
cypress 50.96% <ø> (-0.09%) ⬇️
javascript 60.94% <ø> (+0.19%) ⬆️
python 63.69% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx 73.80% <0.00%> (-1.20%) ⬇️
superset-frontend/src/CRUD/CollectionTable.tsx 61.60% <0.00%> (-1.01%) ⬇️
superset/models/core.py 88.04% <0.00%> (-0.82%) ⬇️
superset/db_engine_specs/presto.py 81.38% <0.00%> (-0.65%) ⬇️
...erset-frontend/src/datasource/DatasourceEditor.jsx 66.95% <0.00%> (-0.15%) ⬇️
superset/tasks/schedules.py 76.36% <0.00%> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a422c76...6d1bf41. Read the comment docs.

@kstrz
Copy link
Contributor Author

kstrz commented Jan 20, 2021

Hey! Could you look at it? @willbarrett @dpgaspar

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 22, 2021
@willbarrett willbarrett merged commit 8ccfdba into apache:master Jan 25, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 26, 2021
* master: (52 commits)
  docs: Updates to Superset Site for 1.0 (apache#12626)
  test(native-filters): scoping tree in native filters modal (apache#12655)
  Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219)
  Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224)
  Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227)
  feat(native-filters): apply scoping of native filters to dashboard (apache#12716)
  Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223)
  Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245)
  fix: missing select menu background (apache#12759)
  fix(explore): incorrect missing datasource condition (apache#12758)
  feat: default timepicker to last week when dataset is changed (apache#12609)
  feat(explore): allow opening charts with missing dataset (apache#12705)
  chore: upgrade Cypress to 6.2.1 (apache#12605)
  refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218)
  feat: Adding option to set_database_uri CLI command (apache#12740)
  docs: Fixed typo on line 348 (apache#12739)
  Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214)
  docs: Remove gatsby-plugin-offline (apache#12693)
  test: oracle engine spec (apache#12615)
  test: hive db engine spec (apache#12520)
  ...
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants