Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates to Superset Site for 1.0 #12626

Merged
merged 9 commits into from Jan 26, 2021

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Jan 20, 2021

SUMMARY

Updated all screenshots to now showcase Superset 1.0 design.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-01-20 at 1 35 51 PM

Screen Shot 2021-01-20 at 1 35 04 PM

TEST PLAN

  • Check for any spelling / grammar issues
  • Check /docs/creating-charts-dashboards/first-dashboard
  • Check /docs/creating-charts-dashboards/exploring-data

@srinify srinify changed the title Updates to Superset Site for 1.0 docs: Updates to Superset Site for 1.0 Jan 20, 2021
@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #12626 (2c3d44a) into master (e7def7e) will decrease coverage by 3.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12626      +/-   ##
==========================================
- Coverage   66.80%   63.61%   -3.20%     
==========================================
  Files        1017      486     -531     
  Lines       49730    29984   -19746     
  Branches     4864        0    -4864     
==========================================
- Hits        33221    19073   -14148     
+ Misses      16386    10911    -5475     
+ Partials      123        0     -123     
Flag Coverage Δ
cypress ?
javascript ?
python 63.61% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/db_engine_specs/mysql.py 89.79% <0.00%> (-2.05%) ⬇️
superset/models/core.py 87.77% <0.00%> (-1.09%) ⬇️
superset/views/core.py 74.85% <0.00%> (-0.45%) ⬇️
superset/connectors/sqla/models.py 90.45% <0.00%> (-0.14%) ⬇️
...nd/src/dashboard/util/isInDifferentFilterScopes.js
...frontend/src/explore/components/DataTablesPane.tsx
...rc/dashboard/components/gridComponents/Divider.jsx
superset-frontend/src/utils/common.js
... and 527 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7def7e...2c3d44a. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should undo the package-lock.json file changes
no reason you should push this right?

- Download the latest Superset version from [Pypi here](https://pypi.org/project/apache-superset/)
- Setup Superset locally with one command
using [Docker Compose](docs/installation/installing-superset-using-docker-compose)
- Download the [Docker image](https://hub.docker.com/r/apache/incubator-superset) from Dockerhub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to point to https://hub.docker.com/r/apache/superset now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixing now!

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like package.json wasn't changed. can you undo the change for package-lock.json?

@srinify srinify merged commit 017f11f into apache:master Jan 26, 2021
amitmiran137 added a commit to nielsen-oss/superset that referenced this pull request Jan 26, 2021
* master: (52 commits)
  docs: Updates to Superset Site for 1.0 (apache#12626)
  test(native-filters): scoping tree in native filters modal (apache#12655)
  Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219)
  Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224)
  Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227)
  feat(native-filters): apply scoping of native filters to dashboard (apache#12716)
  Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223)
  Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245)
  fix: missing select menu background (apache#12759)
  fix(explore): incorrect missing datasource condition (apache#12758)
  feat: default timepicker to last week when dataset is changed (apache#12609)
  feat(explore): allow opening charts with missing dataset (apache#12705)
  chore: upgrade Cypress to 6.2.1 (apache#12605)
  refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218)
  feat: Adding option to set_database_uri CLI command (apache#12740)
  docs: Fixed typo on line 348 (apache#12739)
  Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214)
  docs: Remove gatsby-plugin-offline (apache#12693)
  test: oracle engine spec (apache#12615)
  test: hive db engine spec (apache#12520)
  ...
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants