-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alert/report): alert modal loading dropdown options #13222
Conversation
177abd2
to
635c16d
Compare
@lilykuang won't using #12663 help on this case? |
Codecov Report
@@ Coverage Diff @@
## master #13222 +/- ##
===========================================
+ Coverage 53.06% 77.03% +23.96%
===========================================
Files 489 853 +364
Lines 17314 44728 +27414
Branches 4482 5374 +892
===========================================
+ Hits 9187 34454 +25267
- Misses 8127 10151 +2024
- Partials 0 123 +123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
The issue could reproduce with following steps:
Expect:
Actual:
Issue happened because load dashboard/database was cached and didn't reload. To fix this issue, api payload returns dashboard_name, database_name and slice_name which format the pre-filled input.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://www.loom.com/share/768062757fdf45b89923321e32dd5c59
TEST PLAN
ADDITIONAL INFORMATION