Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert/report): alert modal loading dropdown options #13222

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Feb 18, 2021

SUMMARY

The issue could reproduce with following steps:

  • go to alert modal
  • start typing name on source/dashboard fields(wait for Loading… finished and no data returned)
  • clear the input and close the modal
  • Open any existing alert
    Expect:
  • see dashboard name and source pre-filled
    Actual:
  • dashboard field show 1 or 2 or 3 (id of dashboard)

Issue happened because load dashboard/database was cached and didn't reload. To fix this issue, api payload returns dashboard_name, database_name and slice_name which format the pre-filled input.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://www.loom.com/share/768062757fdf45b89923321e32dd5c59

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang force-pushed the lily/alert-modal-fix branch from 177abd2 to 635c16d Compare February 18, 2021 23:48
@dpgaspar
Copy link
Member

@lilykuang won't using #12663 help on this case?

@lilykuang lilykuang marked this pull request as ready for review February 19, 2021 18:41
@codecov-io
Copy link

codecov-io commented Feb 19, 2021

Codecov Report

Merging #13222 (635c16d) into master (2ce7982) will increase coverage by 23.96%.
The diff coverage is 67.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13222       +/-   ##
===========================================
+ Coverage   53.06%   77.03%   +23.96%     
===========================================
  Files         489      853      +364     
  Lines       17314    44728    +27414     
  Branches     4482     5374      +892     
===========================================
+ Hits         9187    34454    +25267     
- Misses       8127    10151     +2024     
- Partials        0      123      +123     
Flag Coverage Δ
cypress 58.47% <66.79%> (+5.41%) ⬆️
javascript 62.18% <47.63%> (?)
python 80.50% <81.98%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <ø> (+11.50%) ⬆️
superset-frontend/src/chart/ChartContainer.jsx 100.00% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx 77.02% <0.00%> (+0.31%) ⬆️
...perset-frontend/src/common/components/Dropdown.tsx 54.76% <ø> (+4.76%) ⬆️
.../src/common/components/Tooltip/Tooltip.stories.tsx 0.00% <0.00%> (ø)
...t-frontend/src/common/components/Tooltip/index.tsx 100.00% <ø> (ø)
...perset-frontend/src/components/AlteredSliceTag.jsx 98.66% <ø> (+6.66%) ⬆️
superset-frontend/src/components/CachedLabel.jsx 42.10% <ø> (ø)
...perset-frontend/src/components/CopyToClipboard.jsx 60.00% <0.00%> (+2.85%) ⬆️
...t-frontend/src/components/DynamicPlugins/index.tsx 27.65% <ø> (+4.40%) ⬆️
... and 869 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d1e80...635c16d. Read the comment docs.

@dpgaspar dpgaspar merged commit d8bd8ec into apache:master Feb 22, 2021
@dpgaspar dpgaspar deleted the lily/alert-modal-fix branch February 22, 2021 01:59
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants