-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters #14313
Conversation
664913b
to
e3b2cc6
Compare
7e38f2b
to
b2b371c
Compare
Codecov Report
@@ Coverage Diff @@
## master #14313 +/- ##
==========================================
- Coverage 77.18% 77.17% -0.01%
==========================================
Files 954 954
Lines 48134 48171 +37
Branches 5985 5998 +13
==========================================
+ Hits 37151 37177 +26
- Misses 10786 10797 +11
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…e and Select native filters (#14313) * Implement adhoc filters in Range and Select native filters * Add time picker * Remove additional filters from datamask * Create separate stylesheet for AdhocFilterControl in native filters * Rename Time picker to Time range * Fix columns in AdhocFilter empty when creating a new filter * Skip flaky test (cherry picked from commit 20ab086)
…e and Select native filters (apache#14313) * Implement adhoc filters in Range and Select native filters * Add time picker * Remove additional filters from datamask * Create separate stylesheet for AdhocFilterControl in native filters * Rename Time picker to Time range * Fix columns in AdhocFilter empty when creating a new filter * Skip flaky test
SUMMARY
Adds an Adhoc Filters and Time Picker controls to native filters modal - works with Range and Select filters.
Setting an adhoc filter or a time picker affects what values (or a range of values) can be chosen from a filter.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-04-26.at.14.45.03.mov
TEST PLAN
ADDITIONAL INFORMATION
@junlincc @villebro @ktmud